From baf56d0dd062bf636e844185fdb630b83bc6ba4a Mon Sep 17 00:00:00 2001
From: Isma <71719097+Doozers@users.noreply.github.com>
Date: Fri, 22 Dec 2023 10:59:17 +0100
Subject: [PATCH] fix: review comments

Signed-off-by: Isma <71719097+Doozers@users.noreply.github.com>
---
 .gitignore                          | 1 -
 pgeth/engine.go                     | 8 +++-----
 plugins/pgeth-monitoring/.gitignore | 1 -
 3 files changed, 3 insertions(+), 7 deletions(-)
 delete mode 100644 plugins/pgeth-monitoring/.gitignore

diff --git a/.gitignore b/.gitignore
index 409a8f0204..62a4b3d7bc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -53,4 +53,3 @@ tests/spec-tests/
 #pgeth
 
 !plugin/.gitkeep
-plugins/*/
diff --git a/pgeth/engine.go b/pgeth/engine.go
index 678c4a0875..67a99d998a 100644
--- a/pgeth/engine.go
+++ b/pgeth/engine.go
@@ -56,8 +56,8 @@ func (p *PluginEngine) Version(ctx context.Context) error {
 	var plugins []*Plugin
 
 	// load monitoring plugin
-	if pluginMonitoringDirectory := os.Getenv("PGETH_MONITORING_CONFIG"); len(pluginMonitoringDirectory) != 0 {
-		monitoringDetails, err := p.loadPluginDetails(pluginMonitoringDirectory)
+	if pluginConfigFile := os.Getenv("PGETH_MONITORING_CONFIG"); len(pluginConfigFile) != 0 {
+		monitoringDetails, err := p.loadPluginDetails(pluginConfigFile)
 		if err != nil {
 			return err
 		}
@@ -68,12 +68,11 @@ func (p *PluginEngine) Version(ctx context.Context) error {
 		})
 	}
 
-	errChan := make(chan error)
-
 	for _, plug := range plugins {
 		plug.Version()
 	}
 
+	errChan := make(chan error)
 	go func() {
 		for {
 			select {
@@ -111,7 +110,6 @@ func (p *PluginEngine) Start(ctx context.Context) error {
 	}
 
 	errChan := make(chan error)
-
 	for _, plug := range plugins {
 		go func(_plug *Plugin) {
 			defer func() {
diff --git a/plugins/pgeth-monitoring/.gitignore b/plugins/pgeth-monitoring/.gitignore
deleted file mode 100644
index fa6ba895f2..0000000000
--- a/plugins/pgeth-monitoring/.gitignore
+++ /dev/null
@@ -1 +0,0 @@
-plugin.so