From bd6fc4ea6a0caebaf04089d22bde0c3c7ef53d39 Mon Sep 17 00:00:00 2001 From: bnovil Date: Wed, 4 Oct 2023 21:42:52 +0800 Subject: [PATCH] resolve reviews --- ethclient/gethclient/gethclient.go | 4 ++-- ethclient/gethclient/gethclient_test.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ethclient/gethclient/gethclient.go b/ethclient/gethclient/gethclient.go index 3fe84c9970..953be3f7e8 100644 --- a/ethclient/gethclient/gethclient.go +++ b/ethclient/gethclient/gethclient.go @@ -246,9 +246,9 @@ func (ec *Client) TraceBlock(ctx context.Context, blob []byte, config *tracers.T } // TraceBlockByNumber returns the structured logs created during the execution of EVM -func (ec *Client) TraceBlockByNumber(ctx context.Context, number rpc.BlockNumber, config *tracers.TraceConfig) ([]*TxTraceResult, error) { +func (ec *Client) TraceBlockByNumber(ctx context.Context, number *big.Int, config *tracers.TraceConfig) ([]*TxTraceResult, error) { var result []*TxTraceResult - err := ec.c.CallContext(ctx, &result, "debug_traceBlockByNumber", number, config) + err := ec.c.CallContext(ctx, &result, "debug_traceBlockByNumber", toBlockNumArg(number), config) return result, err } diff --git a/ethclient/gethclient/gethclient_test.go b/ethclient/gethclient/gethclient_test.go index 3aed246b2a..3139494bff 100644 --- a/ethclient/gethclient/gethclient_test.go +++ b/ethclient/gethclient/gethclient_test.go @@ -768,19 +768,19 @@ func testTraceBlockByNumber(t *testing.T, client *rpc.Client) { ec := New(client) var testSuite = []struct { - blockNumber rpc.BlockNumber + blockNumber *big.Int config *tracers.TraceConfig expectErr error expect []*TxTraceResult }{ { - blockNumber: 1, + blockNumber: big.NewInt(1), config: nil, expectErr: nil, expect: []*TxTraceResult{{TxHash: testTransactionHash}}, }, { - blockNumber: 1, + blockNumber: big.NewInt(1), config: &tracers.TraceConfig{ Config: &logger.Config{ EnableMemory: true,