From be6e93eedbbc99e3870c2d9aac72c0b075b08c31 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Wed, 5 Feb 2025 09:10:57 +0100 Subject: [PATCH] chore(ci): linting job changes regarding goheader (#116) `goheader` only needs to be run on files changed in the current PR as it will otherwise suggest updating copyright years on untouched files. The other linters, however, should be run in the same manner as a local invocation --- .github/workflows/golangci-lint.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index e1f4e8b074..fc1968ed48 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -22,13 +22,17 @@ jobs: - uses: actions/setup-go@v5 with: go-version: stable - - name: golangci-lint + - name: goheader + # The goheader linter is only enabled in the CI so that it runs only on modified or new files + # (see only-new-issues: true). It is disabled in .golangci.yml because + # golangci-lint running locally is not aware of new/modified files compared to the base + # commit of a pull request, and we want to avoid reporting invalid goheader errors. uses: golangci/golangci-lint-action@v6 with: version: v1.60 only-new-issues: true - # The goheader linter is enabled so that it runs only on modified or new files - # (see only-new-issues: true). Note it is disabled in .golangci.yml because - # golangci-lint is not aware of new/modified files compared to the last git commit, - # and we want to avoid reporting invalid goheader errors when running the linter locally. - args: --enable goheader + args: --enable-only goheader + - name: golangci-lint + uses: golangci/golangci-lint-action@v6 + with: + version: v1.60