forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 18:32:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

signer: check calldata length even if no ABI signature is present

Browse source
This commit is contained in:
Martin Holst Swende 2018-09-14 15:57:02 +02:00
parent 8e41a5c0c6
commit c03d2bcb51
No known key found for this signature in database
GPG key ID: 683B438C05A5DDF0
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
signer/core/validation.go
View file

@ -63,6 +63,9 @@ func (v *Validator) validateCallData(msgs *ValidationMessages, data []byte, meth
msgs.warn("Tx contains data which is not valid ABI") msgs.warn("Tx contains data which is not valid ABI")
return return
} }
if arglen := len(data) - 4; arglen%32 != 0 {
msgs.warn(fmt.Sprintf("Not ABI-encoded data; length should be a multiple of 32 (was %d)", arglen))
}
var ( var (
info *decodedCallData info *decodedCallData
err error err error