forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-11 06:23:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

metrics: spin up ticker routine only if metrics is enabled

Browse source
This commit is contained in:
Gary Rong 2025-02-27 13:10:20 +08:00
parent 939a804146
commit c0cd847f8a
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
metrics/meter.go
View file

@ -139,10 +139,16 @@ type meterTicker struct {
func (ma *meterTicker) add(m *Meter) { func (ma *meterTicker) add(m *Meter) {
ma.mu.Lock() ma.mu.Lock()
defer ma.mu.Unlock() defer ma.mu.Unlock()
ma.meters[m] = struct{}{} ma.meters[m] = struct{}{}
if !ma.started { if !ma.started {
ma.started = true ma.started = true
go ma.loop()
// Avoid starting the ticker routine if metrics are disabled,
// as all created meters will remain inactive.
if Enabled() {
go ma.loop()
}
} }
} }
@ -157,9 +163,6 @@ func (ma *meterTicker) remove(m *Meter) {
func (ma *meterTicker) loop() { func (ma *meterTicker) loop() {
ticker := time.NewTicker(5 * time.Second) ticker := time.NewTicker(5 * time.Second)
for range ticker.C { for range ticker.C {
if !metricsEnabled {
continue
}
ma.mu.RLock() ma.mu.RLock()
for meter := range ma.meters { for meter := range ma.meters {
meter.tick() meter.tick()