From c145287e87690e523975e1919d1b34538771de93 Mon Sep 17 00:00:00 2001 From: JukLee0ira Date: Fri, 16 May 2025 12:01:36 +0800 Subject: [PATCH] node: allow JWT pass by file only #24579 (#1035) --- cmd/utils/flags.go | 2 +- node/node.go | 13 ++----------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go index 5c1e515560..deef53e1b9 100644 --- a/cmd/utils/flags.go +++ b/cmd/utils/flags.go @@ -418,7 +418,7 @@ var ( } JWTSecretFlag = &cli.StringFlag{ Name: "authrpc-jwtsecret", - Usage: "JWT secret (or path to a jwt secret) to use for authenticated RPC endpoints", + Usage: "Path to a JWT secret to use for authenticated RPC endpoints", Category: flags.APICategory, } diff --git a/node/node.go b/node/node.go index d5bb81f437..117aeebd23 100644 --- a/node/node.go +++ b/node/node.go @@ -354,17 +354,8 @@ func (n *Node) closeDataDir() { // or from the default location. If neither of those are present, it generates // a new secret and stores to the default location. func (n *Node) obtainJWTSecret(cliParam string) ([]byte, error) { - var fileName string - if len(cliParam) > 0 { - // If a plaintext secret was provided via cli flags, use that - jwtSecret := common.FromHex(cliParam) - if len(jwtSecret) == 32 && strings.HasPrefix(cliParam, "0x") { - log.Warn("Plaintext JWT secret provided, please consider passing via file") - return jwtSecret, nil - } - // path provided - fileName = cliParam - } else { + fileName := cliParam + if len(fileName) == 0 { // no path provided, use default fileName = n.ResolvePath(datadirJWTKey) }