forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-17 09:23:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

accounts/abi: simplify readBool

Browse source 
No other read* function checks the length, so don't do it in readBool.
This commit is contained in:
Felix Lange 2017-09-10 12:16:17 +02:00 committed by Bas van Kervel
parent c86e965cb9
commit c156f68092
No known key found for this signature in database
GPG key ID: BFB23B252EF5812B
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
accounts/abi/unpack.go
View file

@ -60,12 +60,8 @@ func readInteger(kind reflect.Kind, b []byte) interface{} {
// reads a bool // reads a bool
func readBool(word []byte) (bool, error) { func readBool(word []byte) (bool, error) {
if len(word) != 32 { for _, b := range word[:31] {
return false, fmt.Errorf("abi: fatal error: incorrect word length") if b != 0 {
}
for i, b := range word {
if b != 0 && i != 31 {
return false, errBadBool return false, errBadBool
} }
} }