forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-17 18:30:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #498 from XinFinOrg/ppx-01

Browse source 
PPX-01 add verification of vote signer belonging to masternodes
This commit is contained in:
wgr523 2024-04-01 20:48:16 +08:00 committed by GitHub
commit c16bd66a8d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
consensus/XDPoS/engines/engine_v2/vote.go
View file

@ -122,8 +122,20 @@ func (x *XDPoS_v2) verifyVotes(chain consensus.ChainReader, votes map[common.Has
for h, vote := range votes { for h, vote := range votes {
go func(hash common.Hash, v *types.Vote) { go func(hash common.Hash, v *types.Vote) {
defer wg.Done() defer wg.Done()
if v.GetSigner() != emptySigner { signerAddress := v.GetSigner()
// verify before if signerAddress != emptySigner {
// verify that signer belongs to the final masternodes, we have not do so in previous steps
if len(masternodes) == 0 {
log.Error("[verifyVotes] empty masternode list detected when verifying message signatures")
}
for _, mn := range masternodes {
if mn == signerAddress {
return
}
}
// if signer does not belong to final masternodes, we remove the signer
v.SetSigner(emptySigner)
log.Debug("[verifyVotes] find a vote does not belong to final masternodes", "signer", signerAddress)
return return
} }
signedVote := types.VoteSigHash(&types.VoteForSign{ signedVote := types.VoteSigHash(&types.VoteForSign{