From c173c1b73f4e89ba3f9473865f75d183dab5a6c4 Mon Sep 17 00:00:00 2001 From: Dylan Vassallo Date: Mon, 9 Sep 2024 12:50:00 +0200 Subject: [PATCH] core/vm: remove panic when address is not present --- core/vm/operations_acl.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/core/vm/operations_acl.go b/core/vm/operations_acl.go index 289da44be3..1cdaaba516 100644 --- a/core/vm/operations_acl.go +++ b/core/vm/operations_acl.go @@ -39,16 +39,10 @@ func makeGasSStoreFunc(clearingRefund uint64) gasFunc { cost = uint64(0) ) // Check slot presence in the access list - if addrPresent, slotPresent := evm.StateDB.SlotInAccessList(contract.Address(), slot); !slotPresent { + if _, slotPresent := evm.StateDB.SlotInAccessList(contract.Address(), slot); !slotPresent { cost = params.ColdSloadCostEIP2929 // If the caller cannot afford the cost, this change will be rolled back evm.StateDB.AddSlotToAccessList(contract.Address(), slot) - if !addrPresent { - // Once we're done with YOLOv2 and schedule this for mainnet, might - // be good to remove this panic here, which is just really a - // canary to have during testing - panic("impossible case: address was not present in access list during sstore op") - } } value := common.Hash(y.Bytes32())