forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 18:32:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

p2p/discover: return nextTime from run()

Browse source
This commit is contained in:
Felix Lange 2024-04-20 10:07:20 +02:00
parent dc3f78bb81
commit c1afb3c0cc
2 changed files with 44 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
p2p/discover/table.go
View file

@ -66,7 +66,7 @@ type Table struct {
mutex sync.Mutex // protects buckets, bucket content, nursery, rand
buckets [nBuckets]*bucket // index of known nodes by distance
nursery []*node // bootstrap nodes
rand *reseedingRandom // source of randomness, periodically reseeded
rand reseedingRandom // source of randomness, periodically reseeded
ips netutil.DistinctNetSet
revalidation tableRevalidation
@ -77,7 +77,7 @@ type Table struct {
// loop channels
refreshReq chan chan struct{}
revalidateResp chan revalidationResponse
revalResponseCh chan revalidationResponse
addNodeCh chan addNodeRequest
addNodeHandled chan struct{}
findFailureCh chan *node
@ -120,14 +120,13 @@ func newTable(t transport, db *enode.DB, cfg Config) (*Table, error) {
cfg: cfg,
log: cfg.Log,
refreshReq: make(chan chan struct{}),
revalidateResp: make(chan revalidationResponse),
revalResponseCh: make(chan revalidationResponse),
addNodeCh: make(chan addNodeRequest),
addNodeHandled: make(chan struct{}),
findFailureCh: make(chan *node),
initDone: make(chan struct{}),
closeReq: make(chan struct{}),
closed: make(chan struct{}),
rand: new(reseedingRandom),
ips: netutil.DistinctNetSet{Subnet: tableSubnet, Limit: tableIPLimit},
}
for i := range tab.buckets {
@ -349,17 +348,18 @@ func (tab *Table) loop() {
loop:
for {
nextTime := tab.revalidation.run(tab, tab.cfg.Clock.Now())
revalTimer.Schedule(nextTime)
reseedRandTimer.Schedule(tab.rand.nextReseedTime())
revalTimer.Schedule(tab.revalidation.nextTime())
select {
case <-reseedRandTimer.C():
tab.rand.seed(tab.cfg.Clock.Now())
case <-revalTimer.C():
tab.revalidation.run(tab, mclock.Now())
case r := <-tab.revalidateResp:
case r := <-tab.revalResponseCh:
tab.revalidation.handleResponse(tab, r)
case addreq := <-tab.addNodeCh:

34
p2p/discover/table_reval.go
View file

@ -50,7 +50,7 @@ func (tr *tableRevalidation) init(cfg *Config) {
// nodeAdded is called when the table receives a new node.
func (tr *tableRevalidation) nodeAdded(tab *Table, n *node) {
tr.newNodes.push(n, tab.cfg.Clock.Now(), tab.rand)
tr.newNodes.push(n, tab.cfg.Clock.Now(), &tab.rand)
}
// nodeRemoved is called when a node was removed from the table.
@ -61,22 +61,26 @@ func (tr *tableRevalidation) nodeRemoved(n *node) {
}
}
// nextTime returns the next time run() should be invoked.
// The Table main loop uses this to schedule a timer.
func (tr *tableRevalidation) nextTime() mclock.AbsTime {
return min(tr.newNodes.nextTime, tr.nodes.nextTime)
// run performs node revalidation.
// It returns the next time it should be invoked, which is used in the Table main loop
// to schedule a timer. However, run can be called at any time.
func (tr *tableRevalidation) run(tab *Table, now mclock.AbsTime) (nextTime mclock.AbsTime) {
if n := tr.newNodes.get(now, &tab.rand, tr.activeReq); n != nil {
tr.startRequest(tab, n, true)
tr.newNodes.schedule(now, &tab.rand)
}
if n := tr.nodes.get(now, &tab.rand, tr.activeReq); n != nil {
tr.startRequest(tab, n, false)
tr.nodes.schedule(now, &tab.rand)
}
// run performs node revalidation.
func (tr *tableRevalidation) run(tab *Table, now mclock.AbsTime) {
if n := tr.newNodes.get(now, tab.rand, tr.activeReq); n != nil {
tr.startRequest(tab, n, true)
tr.newNodes.schedule(now, tab.rand)
if tr.newNodes.nextTime == never {
return tr.nodes.nextTime
}
if n := tr.nodes.get(now, tab.rand, tr.activeReq); n != nil {
tr.startRequest(tab, n, false)
tr.nodes.schedule(now, tab.rand)
if tr.nodes.nextTime == never {
return tr.newNodes.nextTime
}
return min(tr.newNodes.nextTime, tr.nodes.nextTime)
}
// startRequest spawns a revalidation request for node n.
@ -111,7 +115,7 @@ func (tab *Table) doRevalidate(resp revalidationResponse, node *enode.Node) {
}
select {
case tab.revalidateResp <- resp:
case tab.revalResponseCh <- resp:
case <-tab.closed:
}
}
@ -150,7 +154,7 @@ func (tr *tableRevalidation) handleResponse(tab *Table, resp revalidationRespons
// Move node over to main queue after first validation.
if resp.isNewNode {
tr.newNodes.remove(n)
tr.nodes.push(n, tab.cfg.Clock.Now(), tab.rand)
tr.nodes.push(n, tab.cfg.Clock.Now(), &tab.rand)
}
// Store potential seeds in database.