From c4298c95ee09489d02c3c116490bc074ac1eaeb4 Mon Sep 17 00:00:00 2001 From: Lin Corey Date: Thu, 8 Nov 2018 14:38:36 +0800 Subject: [PATCH] ethdb: small refactor to test file: 1.remove unused parameter 2.rename variable in camelCase way --- ethdb/database_test.go | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/ethdb/database_test.go b/ethdb/database_test.go index 382fedbf9e..27406fc5a5 100644 --- a/ethdb/database_test.go +++ b/ethdb/database_test.go @@ -46,7 +46,7 @@ func newTestLDB() (*ethdb.LDBDatabase, func()) { } } -var test_values = []string{"", "a", "1251", "\x00123\x00"} +var testValues = []string{"", "a", "1251", "\x00123\x00"} func TestLDB_PutGet(t *testing.T) { db, remove := newTestLDB() @@ -61,14 +61,14 @@ func TestMemoryDB_PutGet(t *testing.T) { func testPutGet(db ethdb.Database, t *testing.T) { t.Parallel() - for _, k := range test_values { + for _, k := range testValues { err := db.Put([]byte(k), nil) if err != nil { t.Fatalf("put failed: %v", err) } } - for _, k := range test_values { + for _, k := range testValues { data, err := db.Get([]byte(k)) if err != nil { t.Fatalf("get failed: %v", err) @@ -83,14 +83,14 @@ func testPutGet(db ethdb.Database, t *testing.T) { t.Fatalf("expect to return a not found error") } - for _, v := range test_values { + for _, v := range testValues { err := db.Put([]byte(v), []byte(v)) if err != nil { t.Fatalf("put failed: %v", err) } } - for _, v := range test_values { + for _, v := range testValues { data, err := db.Get([]byte(v)) if err != nil { t.Fatalf("get failed: %v", err) @@ -100,14 +100,14 @@ func testPutGet(db ethdb.Database, t *testing.T) { } } - for _, v := range test_values { + for _, v := range testValues { err := db.Put([]byte(v), []byte("?")) if err != nil { t.Fatalf("put override failed: %v", err) } } - for _, v := range test_values { + for _, v := range testValues { data, err := db.Get([]byte(v)) if err != nil { t.Fatalf("get failed: %v", err) @@ -117,7 +117,7 @@ func testPutGet(db ethdb.Database, t *testing.T) { } } - for _, v := range test_values { + for _, v := range testValues { orig, err := db.Get([]byte(v)) if err != nil { t.Fatalf("get failed: %v", err) @@ -132,14 +132,14 @@ func testPutGet(db ethdb.Database, t *testing.T) { } } - for _, v := range test_values { + for _, v := range testValues { err := db.Delete([]byte(v)) if err != nil { t.Fatalf("delete %q failed: %v", v, err) } } - for _, v := range test_values { + for _, v := range testValues { _, err := db.Get([]byte(v)) if err == nil { t.Fatalf("got deleted value %q", v) @@ -150,14 +150,14 @@ func testPutGet(db ethdb.Database, t *testing.T) { func TestLDB_ParallelPutGet(t *testing.T) { db, remove := newTestLDB() defer remove() - testParallelPutGet(db, t) + testParallelPutGet(db) } func TestMemoryDB_ParallelPutGet(t *testing.T) { - testParallelPutGet(ethdb.NewMemDatabase(), t) + testParallelPutGet(ethdb.NewMemDatabase()) } -func testParallelPutGet(db ethdb.Database, t *testing.T) { +func testParallelPutGet(db ethdb.Database) { const n = 8 var pending sync.WaitGroup