forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-18 19:00:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/txpool/blobpool: remove unused adds slice in Add()

Browse source 
The adds slice in BlobPool.Add() is populated but never read,
causing unnecessary memory allocation and WithoutBlobTxSidecar()
calls for each successfully added transaction. Remove the dead
code to reduce allocations in the hot path.

Fixes #33871
This commit is contained in:
ionodeionode 2026-02-24 15:10:58 +07:00
parent c2e1785a48
commit c7adf4b31a
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/txpool/blobpool/blobpool.go
View file

@ -1476,17 +1476,12 @@ func (p *BlobPool) AvailableBlobs(vhashes []common.Hash) int {
// Add inserts a set of blob transactions into the pool if they pass validation (both
// consensus validity and pool restrictions).
func (p *BlobPool) Add(txs []*types.Transaction, sync bool) []error {
var (
errs = make([]error, len(txs))
adds = make([]*types.Transaction, 0, len(txs))
)
errs := make([]error, len(txs))
for i, tx := range txs {
if errs[i] = p.ValidateTxBasics(tx); errs[i] != nil {
continue
}
if errs[i] = p.add(tx); errs[i] == nil {
adds = append(adds, tx.WithoutBlobTxSidecar())
}
errs[i] = p.add(tx)
}
return errs
}