forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-18 02:40:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

crypto/bn256: refactor to use bitutil.TestBytes #32435 (#1436)

Browse source 
Co-authored-by: cui <cuiweixie@gmail.com>
This commit is contained in:
Daniel Liu 2025-09-06 17:15:07 +08:00 committed by GitHub
parent 57612d9826
commit c7f17cb300
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
crypto/bn256/gnark/g1.go
View file

@ -4,6 +4,7 @@ import (
"errors" "errors"
"math/big" "math/big"
"github.com/XinFinOrg/XDPoSChain/common/bitutil"
"github.com/consensys/gnark-crypto/ecc/bn254" "github.com/consensys/gnark-crypto/ecc/bn254"
) )
@ -43,7 +44,7 @@ func (g *G1) Unmarshal(buf []byte) (int, error) {
return 0, errors.New("invalid G1 point size") return 0, errors.New("invalid G1 point size")
} }
if allZeroes(buf[:64]) { if !bitutil.TestBytes(buf[:64]) {
// point at infinity // point at infinity
g.inner.X.SetZero() g.inner.X.SetZero()
g.inner.Y.SetZero() g.inner.Y.SetZero()
@ -82,12 +83,3 @@ func (p *G1) Marshal() []byte {
return output return output
} }
func allZeroes(buf []byte) bool {
for i := range buf {
if buf[i] != 0 {
return false
}
}
return true
}

3
crypto/bn256/gnark/g2.go
View file

@ -3,6 +3,7 @@ package bn256
import ( import (
"errors" "errors"
"github.com/XinFinOrg/XDPoSChain/common/bitutil"
"github.com/consensys/gnark-crypto/ecc/bn254" "github.com/consensys/gnark-crypto/ecc/bn254"
) )
@ -31,7 +32,7 @@ func (g *G2) Unmarshal(buf []byte) (int, error) {
return 0, errors.New("invalid G2 point size") return 0, errors.New("invalid G2 point size")
} }
if allZeroes(buf[:128]) { if !bitutil.TestBytes(buf[:128]) {
// point at infinity // point at infinity
g.inner.X.A0.SetZero() g.inner.X.A0.SetZero()
g.inner.X.A1.SetZero() g.inner.X.A1.SetZero()