From ca438bd2e23165ab31aaa12ea2eab30cab263f2f Mon Sep 17 00:00:00 2001 From: Lucas Vasconcelos Date: Wed, 4 Dec 2024 15:27:53 +0100 Subject: [PATCH] p2p: use proper comparison in URLv4 generation --- p2p/enode/urlv4.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2p/enode/urlv4.go b/p2p/enode/urlv4.go index 7a13039d18..a1aa3e5ceb 100644 --- a/p2p/enode/urlv4.go +++ b/p2p/enode/urlv4.go @@ -207,7 +207,7 @@ func (n *Node) URLv4() string { nodeid = fmt.Sprintf("%s.%x", scheme, n.id[:]) } u := url.URL{Scheme: "enode"} - if n.NeedResolve() { + if n.Hostname() != "" { // For DNS nodes: include DNS name, TCP port, and optional UDP port u.User = url.User(nodeid) u.Host = fmt.Sprintf("%s:%d", n.Hostname(), n.TCP())