forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/rawdb: use non-atomic load while holding mutex

Browse source
This commit is contained in:
Marius van der Wijden 2020-04-14 14:40:51 +02:00
parent 090d7b0bdc
commit cbb181c373
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/rawdb/freezer_table.go
View file

@ -552,12 +552,11 @@ func (t *freezerTable) Retrieve(item uint64) ([]byte, error) {
return nil, errOutOfBounds return nil, errOutOfBounds
} }
// Ensure the item was not deleted from the tail either // Ensure the item was not deleted from the tail either
offset := atomic.LoadUint32(&t.itemOffset) if uint64(t.itemOffset) > item {
if uint64(offset) > item {
t.lock.RUnlock() t.lock.RUnlock()
return nil, errOutOfBounds return nil, errOutOfBounds
} }
startOffset, endOffset, filenum, err := t.getBounds(item - uint64(offset)) startOffset, endOffset, filenum, err := t.getBounds(item - uint64(t.itemOffset))
if err != nil { if err != nil {
t.lock.RUnlock() t.lock.RUnlock()
return nil, err return nil, err