forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 10:22:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: remove some test-skips that are no longer needed

Browse source
This commit is contained in:
Martin Holst Swende 2024-08-08 09:57:36 +02:00
parent ea7da4fd40
commit d067f2ce25
No known key found for this signature in database
GPG key ID: 683B438C05A5DDF0
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/transaction_test.go
View file

@ -26,20 +26,14 @@ func TestTransaction(t *testing.T) {
t.Parallel() t.Parallel()
txt := new(testMatcher) txt := new(testMatcher)
// These can't be parsed, invalid hex in RLP
txt.skipLoad("^ttWrongRLP/.*")
// We don't allow more than uint64 in gas amount // We don't allow more than uint64 in gas amount
// This is a pseudo-consensus vulnerability, but not in practice // This is a pseudo-consensus vulnerability, but not in practice
// because of the gas limit // because of the gas limit
txt.skipLoad("^ttGasLimit/TransactionWithGasLimitxPriceOverflow.json") txt.skipLoad("^ttGasLimit/TransactionWithGasLimitxPriceOverflow.json")
// We _do_ allow more than uint64 in gas price, as opposed to the tests // We _do_ allow more than uint64 in gas price, as opposed to the tests
// This is also not a concern, as long as tx.Cost() uses big.Int for // This is also not a concern, as long as tx.Cost() uses big.Int for
// calculating the final cozt // calculating the final cost
txt.skipLoad(".*TransactionWithGasPriceOverflow.*") txt.skipLoad("^ttGasPrice/TransactionWithGasPriceOverflow.json")
// The nonce is too large for uint64. Not a concern, it means geth won't
// accept transactions at a certain point in the distant future
txt.skipLoad("^ttNonce/TransactionWithHighNonce256.json")
// The maximum value of nonce is 2^64 - 1 // The maximum value of nonce is 2^64 - 1
txt.skipLoad("^ttNonce/TransactionWithHighNonce64Minus1.json") txt.skipLoad("^ttNonce/TransactionWithHighNonce64Minus1.json")