From d1f9037b3f69a3e96dd629aa3417e6f8b9205cd7 Mon Sep 17 00:00:00 2001 From: Martin Holst Swende Date: Thu, 27 Sep 2018 11:08:27 +0200 Subject: [PATCH] signer: fix failing testcases --- signer/core/api_test.go | 2 +- signer/rules/rules_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/signer/core/api_test.go b/signer/core/api_test.go index 845692c9b4..a8aa23896e 100644 --- a/signer/core/api_test.go +++ b/signer/core/api_test.go @@ -19,8 +19,8 @@ package core import ( "bytes" "context" + "errors" "fmt" - "github.com/pkg/errors" "io/ioutil" "math/big" "os" diff --git a/signer/rules/rules_test.go b/signer/rules/rules_test.go index b6060eba73..c2f92d51f2 100644 --- a/signer/rules/rules_test.go +++ b/signer/rules/rules_test.go @@ -74,6 +74,10 @@ func mixAddr(a string) (*common.MixedcaseAddress, error) { type alwaysDenyUI struct{} +func (alwaysDenyUI) OnInputRequired(info core.UserInputRequest) (core.UserInputResponse, error) { + return core.UserInputResponse{}, nil +} + func (alwaysDenyUI) OnSignerStartup(info core.StartupInfo) { } @@ -200,6 +204,11 @@ type dummyUI struct { calls []string } +func (d *dummyUI) OnInputRequired(info core.UserInputRequest) (core.UserInputResponse, error) { + d.calls = append(d.calls, "OnInputRequired") + return core.UserInputResponse{}, nil +} + func (d *dummyUI) ApproveTx(request *core.SignTxRequest) (core.SignTxResponse, error) { d.calls = append(d.calls, "ApproveTx") return core.SignTxResponse{}, core.ErrRequestDenied @@ -509,6 +518,11 @@ type dontCallMe struct { t *testing.T } +func (d *dontCallMe) OnInputRequired(info core.UserInputRequest) (core.UserInputResponse, error) { + d.t.Fatalf("Did not expect next-handler to be called") + return core.UserInputResponse{}, nil +} + func (d *dontCallMe) OnSignerStartup(info core.StartupInfo) { }