metrics: break loop as soon as flags have been set

metrics/metrics.go

@@ -39,19 +39,35 @@ func init() {
 	for _, arg := range os.Args {
 		flag := strings.TrimLeft(arg, "-")
 
+		if !Enabled {
+			// only compare enablerFlags when Enable is not set.
 			for _, enabler := range enablerFlags {
-			if !Enabled && flag == enabler {
+				if flag == enabler {
 					log.Info("Enabling metrics collection")
 					Enabled = true
+					// break loop if Enabled flag is already set.
+					break
 				}
 			}
+		}
+
+		if !EnabledExpensive {
+			// only compare expensiveEnablerFlags when EnabledExpensive is not set.
 			for _, enabler := range expensiveEnablerFlags {
-			if !EnabledExpensive && flag == enabler {
+				if flag == enabler {
 					log.Info("Enabling expensive metrics collection")
 					EnabledExpensive = true
+					// break loop if EnabledExpensive flag is already set.
+					break
 				}
 			}
 		}
+
+		// break loop as all flags have been set.
+		if Enabled && EnabledExpensive {
+			break
+		}
+	}
 }
 
 // CollectProcessMetrics periodically collects various metrics about the running