From d6157b121fafea59d6e332a47485028b711998e0 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Mon, 27 Feb 2017 01:50:29 +0100 Subject: [PATCH] all: unify big.Int zero checks Various checks were in use. This commit replaces them all with Int.Sign, which is cheaper and less code. eg templates: func before(x *big.Int) bool { return x.BitLen() == 0 } func after(x *big.Int) bool { return x.Sign() == 0 } func before(x *big.Int) bool { return x.BitLen() > 0 } func after(x *big.Int) bool { return x.Sign() != 0 } func before(x *big.Int) int { return x.Cmp(common.Big0) } func after(x *big.Int) int { return x.Sign() } --- accounts/abi/bind/backends/simulated.go | 2 +- accounts/usbwallet/ledger_wallet.go | 2 +- contracts/chequebook/cheque.go | 6 +++--- contracts/chequebook/cheque_test.go | 2 +- core/headerchain.go | 2 +- core/state/state_object.go | 6 +++--- core/tx_pool.go | 2 +- core/types/transaction.go | 2 +- core/types/transaction_signing.go | 2 +- core/types/transaction_signing_test.go | 2 +- core/vm/common.go | 2 +- core/vm/evm.go | 2 +- core/vm/gas_table.go | 6 +++--- core/vm/instructions.go | 20 ++++++++++---------- internal/ethapi/api.go | 6 +++--- light/state_object.go | 2 +- light/txpool.go | 2 +- swarm/services/swap/swap/swap.go | 5 ++--- 18 files changed, 36 insertions(+), 37 deletions(-) diff --git a/accounts/abi/bind/backends/simulated.go b/accounts/abi/bind/backends/simulated.go index 5e2fcbae76..e21ffe1f8b 100644 --- a/accounts/abi/bind/backends/simulated.go +++ b/accounts/abi/bind/backends/simulated.go @@ -237,7 +237,7 @@ func (b *SimulatedBackend) callContract(ctx context.Context, call ethereum.CallM if call.GasPrice == nil { call.GasPrice = big.NewInt(1) } - if call.Gas == nil || call.Gas.BitLen() == 0 { + if call.Gas == nil || call.Gas.Sign() == 0 { call.Gas = big.NewInt(50000000) } if call.Value == nil { diff --git a/accounts/usbwallet/ledger_wallet.go b/accounts/usbwallet/ledger_wallet.go index 6086660f9a..cedb759940 100644 --- a/accounts/usbwallet/ledger_wallet.go +++ b/accounts/usbwallet/ledger_wallet.go @@ -416,7 +416,7 @@ func (w *ledgerWallet) selfDerive() { break } // If the next account is empty, stop self-derivation, but add it nonetheless - if balance.BitLen() == 0 && nonce == 0 { + if balance.Sign() == 0 && nonce == 0 { empty = true } // We've just self-derived a new account, start tracking it locally diff --git a/contracts/chequebook/cheque.go b/contracts/chequebook/cheque.go index 9a2a5a2a65..bae6f3393c 100644 --- a/contracts/chequebook/cheque.go +++ b/contracts/chequebook/cheque.go @@ -247,7 +247,7 @@ func (self *Chequebook) Issue(beneficiary common.Address, amount *big.Int) (ch * defer self.lock.Unlock() self.lock.Lock() - if amount.Cmp(common.Big0) <= 0 { + if amount.Sign() <= 0 { return nil, fmt.Errorf("amount must be greater than zero (%v)", amount) } if self.balance.Cmp(amount) < 0 { @@ -515,7 +515,7 @@ func (self *Inbox) autoCash(cashInterval time.Duration) { self.quit = nil } // if maxUncashed is set to 0, then autocash on receipt - if cashInterval == time.Duration(0) || self.maxUncashed != nil && self.maxUncashed.Cmp(common.Big0) == 0 { + if cashInterval == time.Duration(0) || self.maxUncashed != nil && self.maxUncashed.Sign() == 0 { return } @@ -597,7 +597,7 @@ func (self *Cheque) Verify(signerKey *ecdsa.PublicKey, contract, beneficiary com amount := new(big.Int).Set(self.Amount) if sum != nil { amount.Sub(amount, sum) - if amount.Cmp(common.Big0) <= 0 { + if amount.Sign() <= 0 { return nil, fmt.Errorf("incorrect amount: %v <= 0", amount) } } diff --git a/contracts/chequebook/cheque_test.go b/contracts/chequebook/cheque_test.go index 85d9231092..4029fd5495 100644 --- a/contracts/chequebook/cheque_test.go +++ b/contracts/chequebook/cheque_test.go @@ -88,7 +88,7 @@ func TestIssueAndReceive(t *testing.T) { t.Fatalf("expected no error, got %v", err) } - if chbook.Balance().Cmp(common.Big0) != 0 { + if chbook.Balance().Sign() != 0 { t.Errorf("expected: %v, got %v", "0", chbook.Balance()) } diff --git a/core/headerchain.go b/core/headerchain.go index a0550a4286..0462759331 100644 --- a/core/headerchain.go +++ b/core/headerchain.go @@ -359,7 +359,7 @@ func (hc *HeaderChain) GetBlockHashesFromHash(hash common.Hash, max uint64) []co break } chain = append(chain, next) - if header.Number.Cmp(common.Big0) == 0 { + if header.Number.Sign() == 0 { break } } diff --git a/core/state/state_object.go b/core/state/state_object.go index ebb103806f..17726dd0cc 100644 --- a/core/state/state_object.go +++ b/core/state/state_object.go @@ -93,7 +93,7 @@ type stateObject struct { // empty returns whether the account is considered empty. func (s *stateObject) empty() bool { - return s.data.Nonce == 0 && s.data.Balance.BitLen() == 0 && bytes.Equal(s.data.CodeHash, emptyCodeHash) + return s.data.Nonce == 0 && s.data.Balance.Sign() == 0 && bytes.Equal(s.data.CodeHash, emptyCodeHash) } // Account is the Ethereum consensus representation of accounts. @@ -243,7 +243,7 @@ func (self *stateObject) CommitTrie(db trie.Database, dbw trie.DatabaseWriter) e func (c *stateObject) AddBalance(amount *big.Int) { // EIP158: We must check emptiness for the objects such that the account // clearing (0,0,0 objects) can take effect. - if amount.Cmp(common.Big0) == 0 { + if amount.Sign() == 0 { if c.empty() { c.touch() } @@ -260,7 +260,7 @@ func (c *stateObject) AddBalance(amount *big.Int) { // SubBalance removes amount from c's balance. // It is used to remove funds from the origin account of a transfer. func (c *stateObject) SubBalance(amount *big.Int) { - if amount.Cmp(common.Big0) == 0 { + if amount.Sign() == 0 { return } c.SetBalance(new(big.Int).Sub(c.Balance(), amount)) diff --git a/core/tx_pool.go b/core/tx_pool.go index b0a8eea0fd..e8d93d20e9 100644 --- a/core/tx_pool.go +++ b/core/tx_pool.go @@ -299,7 +299,7 @@ func (pool *TxPool) validateTx(tx *types.Transaction) error { // Transactions can't be negative. This may never happen // using RLP decoded transactions but may occur if you create // a transaction using the RPC for example. - if tx.Value().Cmp(common.Big0) < 0 { + if tx.Value().Sign() < 0 { return ErrNegativeValue } diff --git a/core/types/transaction.go b/core/types/transaction.go index 9382acb70b..ab0bba4dcd 100644 --- a/core/types/transaction.go +++ b/core/types/transaction.go @@ -42,7 +42,7 @@ var ( // deriveSigner makes a *best* guess about which signer to use. func deriveSigner(V *big.Int) Signer { - if V.BitLen() > 0 && isProtectedV(V) { + if V.Sign() != 0 && isProtectedV(V) { return EIP155Signer{chainId: deriveChainId(V)} } else { return HomesteadSigner{} diff --git a/core/types/transaction_signing.go b/core/types/transaction_signing.go index 7d7b63e9f1..e7eb7c5f0c 100644 --- a/core/types/transaction_signing.go +++ b/core/types/transaction_signing.go @@ -167,7 +167,7 @@ func (s EIP155Signer) WithSignature(tx *Transaction, sig []byte) (*Transaction, cpy.data.R = new(big.Int).SetBytes(sig[:32]) cpy.data.S = new(big.Int).SetBytes(sig[32:64]) cpy.data.V = new(big.Int).SetBytes([]byte{sig[64]}) - if s.chainId.BitLen() > 0 { + if s.chainId.Sign() != 0 { cpy.data.V = big.NewInt(int64(sig[64] + 35)) cpy.data.V.Add(cpy.data.V, s.chainIdMul) } diff --git a/core/types/transaction_signing_test.go b/core/types/transaction_signing_test.go index 3216fcfad3..7f799fb101 100644 --- a/core/types/transaction_signing_test.go +++ b/core/types/transaction_signing_test.go @@ -71,7 +71,7 @@ func TestEIP155ChainId(t *testing.T) { t.Error("didn't expect tx to be protected") } - if tx.ChainId().BitLen() > 0 { + if tx.ChainId().Sign() != 0 { t.Error("expected chain id to be 0 got", tx.ChainId()) } } diff --git a/core/vm/common.go b/core/vm/common.go index ef40c4a957..779cee006d 100644 --- a/core/vm/common.go +++ b/core/vm/common.go @@ -25,7 +25,7 @@ import ( // calculates the memory size required for a step func calcMemSize(off, l *big.Int) *big.Int { - if l.Cmp(common.Big0) == 0 { + if l.Sign() == 0 { return common.Big0 } diff --git a/core/vm/evm.go b/core/vm/evm.go index d1fac6c103..71efcfa458 100644 --- a/core/vm/evm.go +++ b/core/vm/evm.go @@ -120,7 +120,7 @@ func (evm *EVM) Call(caller ContractRef, addr common.Address, input []byte, gas snapshot = evm.StateDB.Snapshot() ) if !evm.StateDB.Exist(addr) { - if PrecompiledContracts[addr] == nil && evm.ChainConfig().IsEIP158(evm.BlockNumber) && value.BitLen() == 0 { + if PrecompiledContracts[addr] == nil && evm.ChainConfig().IsEIP158(evm.BlockNumber) && value.Sign() == 0 { return nil, gas, nil } diff --git a/core/vm/gas_table.go b/core/vm/gas_table.go index fba1eb066e..f1c62df8e7 100644 --- a/core/vm/gas_table.go +++ b/core/vm/gas_table.go @@ -273,7 +273,7 @@ func gasExp(gt params.GasTable, evm *EVM, contract *Contract, stack *Stack, mem func gasCall(gt params.GasTable, evm *EVM, contract *Contract, stack *Stack, mem *Memory, memorySize uint64) (uint64, error) { var ( gas = gt.Calls - transfersValue = stack.Back(2).BitLen() > 0 + transfersValue = stack.Back(2).Sign() != 0 address = common.BigToAddress(stack.Back(1)) eip158 = evm.ChainConfig().IsEIP158(evm.BlockNumber) ) @@ -316,7 +316,7 @@ func gasCall(gt params.GasTable, evm *EVM, contract *Contract, stack *Stack, mem func gasCallCode(gt params.GasTable, evm *EVM, contract *Contract, stack *Stack, mem *Memory, memorySize uint64) (uint64, error) { gas := gt.Calls - if stack.Back(2).BitLen() > 0 { + if stack.Back(2).Sign() != 0 { gas += params.CallValueTransferGas } memoryGas, err := memoryGasCost(mem, memorySize) @@ -362,7 +362,7 @@ func gasSuicide(gt params.GasTable, evm *EVM, contract *Contract, stack *Stack, if eip158 { // if empty and transfers value - if evm.StateDB.Empty(address) && evm.StateDB.GetBalance(contract.Address()).BitLen() > 0 { + if evm.StateDB.Empty(address) && evm.StateDB.GetBalance(contract.Address()).Sign() != 0 { gas += gt.CreateBySuicide } } else if !evm.StateDB.Exist(address) { diff --git a/core/vm/instructions.go b/core/vm/instructions.go index ecef7e6a0d..bfc0a668e4 100644 --- a/core/vm/instructions.go +++ b/core/vm/instructions.go @@ -58,7 +58,7 @@ func opMul(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stac func opDiv(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack) ([]byte, error) { x, y := stack.pop(), stack.pop() - if y.Cmp(common.Big0) != 0 { + if y.Sign() != 0 { stack.push(math.U256(x.Div(x, y))) } else { stack.push(new(big.Int)) @@ -71,12 +71,12 @@ func opDiv(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stac func opSdiv(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack) ([]byte, error) { x, y := math.S256(stack.pop()), math.S256(stack.pop()) - if y.Cmp(common.Big0) == 0 { + if y.Sign() == 0 { stack.push(new(big.Int)) return nil, nil } else { n := new(big.Int) - if evm.interpreter.intPool.get().Mul(x, y).Cmp(common.Big0) < 0 { + if evm.interpreter.intPool.get().Mul(x, y).Sign() < 0 { n.SetInt64(-1) } else { n.SetInt64(1) @@ -93,7 +93,7 @@ func opSdiv(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Sta func opMod(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack) ([]byte, error) { x, y := stack.pop(), stack.pop() - if y.Cmp(common.Big0) == 0 { + if y.Sign() == 0 { stack.push(new(big.Int)) } else { stack.push(math.U256(x.Mod(x, y))) @@ -105,11 +105,11 @@ func opMod(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stac func opSmod(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack) ([]byte, error) { x, y := math.S256(stack.pop()), math.S256(stack.pop()) - if y.Cmp(common.Big0) == 0 { + if y.Sign() == 0 { stack.push(new(big.Int)) } else { n := new(big.Int) - if x.Cmp(common.Big0) < 0 { + if x.Sign() < 0 { n.SetInt64(-1) } else { n.SetInt64(1) @@ -221,7 +221,7 @@ func opEq(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack func opIszero(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack) ([]byte, error) { x := stack.pop() - if x.Cmp(common.Big0) > 0 { + if x.Sign() > 0 { stack.push(new(big.Int)) } else { stack.push(evm.interpreter.intPool.get().SetUint64(1)) @@ -506,7 +506,7 @@ func opJump(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Sta } func opJumpi(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Stack) ([]byte, error) { pos, cond := stack.pop(), stack.pop() - if cond.BitLen() > 0 { + if cond.Sign() != 0 { if !contract.jumpdests.has(contract.CodeHash, contract.Code, pos) { nop := contract.GetOp(pos.Uint64()) return nil, fmt.Errorf("invalid jump destination (%v) %v", nop, pos) @@ -584,7 +584,7 @@ func opCall(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack *Sta // Get the arguments from the memory args := memory.Get(inOffset.Int64(), inSize.Int64()) - if value.BitLen() > 0 { + if value.Sign() != 0 { gas += params.CallStipend } @@ -617,7 +617,7 @@ func opCallCode(pc *uint64, evm *EVM, contract *Contract, memory *Memory, stack // Get the arguments from the memory args := memory.Get(inOffset.Int64(), inSize.Int64()) - if value.BitLen() > 0 { + if value.Sign() != 0 { gas += params.CallStipend } diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go index 6a38272c13..8dc7218cac 100644 --- a/internal/ethapi/api.go +++ b/internal/ethapi/api.go @@ -596,10 +596,10 @@ func (s *PublicBlockChainAPI) doCall(ctx context.Context, args CallArgs, blockNr } // Set default gas & gas price if none were set gas, gasPrice := args.Gas.ToInt(), args.GasPrice.ToInt() - if gas.BitLen() == 0 { + if gas.Sign() == 0 { gas = big.NewInt(50000000) } - if gasPrice.BitLen() == 0 { + if gasPrice.Sign() == 0 { gasPrice = new(big.Int).SetUint64(defaultGasPrice) } @@ -653,7 +653,7 @@ func (s *PublicBlockChainAPI) Call(ctx context.Context, args CallArgs, blockNr r func (s *PublicBlockChainAPI) EstimateGas(ctx context.Context, args CallArgs) (*hexutil.Big, error) { // Binary search the gas requirement, as it may be higher than the amount used var lo, hi uint64 - if (*big.Int)(&args.Gas).BitLen() > 0 { + if (*big.Int)(&args.Gas).Sign() != 0 { hi = (*big.Int)(&args.Gas).Uint64() } else { // Retrieve the current pending block to act as the gas ceiling diff --git a/light/state_object.go b/light/state_object.go index 03d4868cdc..d023270d5f 100644 --- a/light/state_object.go +++ b/light/state_object.go @@ -202,7 +202,7 @@ func (self *StateObject) Copy() *StateObject { // empty returns whether the account is considered empty. func (self *StateObject) empty() bool { - return self.nonce == 0 && self.balance.BitLen() == 0 && bytes.Equal(self.codeHash, emptyCodeHash) + return self.nonce == 0 && self.balance.Sign() == 0 && bytes.Equal(self.codeHash, emptyCodeHash) } // Balance returns the account balance diff --git a/light/txpool.go b/light/txpool.go index 365f02d259..ecd6cfa265 100644 --- a/light/txpool.go +++ b/light/txpool.go @@ -365,7 +365,7 @@ func (pool *TxPool) validateTx(ctx context.Context, tx *types.Transaction) error // Transactions can't be negative. This may never happen // using RLP decoded transactions but may occur if you create // a transaction using the RPC for example. - if tx.Value().Cmp(common.Big0) < 0 { + if tx.Value().Sign() < 0 { return core.ErrNegativeValue } diff --git a/swarm/services/swap/swap/swap.go b/swarm/services/swap/swap/swap.go index d04194960f..a78f1f0e2a 100644 --- a/swarm/services/swap/swap/swap.go +++ b/swarm/services/swap/swap/swap.go @@ -22,7 +22,6 @@ import ( "sync" "time" - "github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/log" ) @@ -120,11 +119,11 @@ func (self *Swap) SetRemote(remote *Profile) { self.lock.Lock() self.remote = remote - if self.Sells && (remote.BuyAt.Cmp(common.Big0) <= 0 || self.local.SellAt.Cmp(common.Big0) <= 0 || remote.BuyAt.Cmp(self.local.SellAt) < 0) { + if self.Sells && (remote.BuyAt.Sign() <= 0 || self.local.SellAt.Sign() <= 0 || remote.BuyAt.Cmp(self.local.SellAt) < 0) { self.Out.Stop() self.Sells = false } - if self.Buys && (remote.SellAt.Cmp(common.Big0) <= 0 || self.local.BuyAt.Cmp(common.Big0) <= 0 || self.local.BuyAt.Cmp(self.remote.SellAt) < 0) { + if self.Buys && (remote.SellAt.Sign() <= 0 || self.local.BuyAt.Sign() <= 0 || self.local.BuyAt.Cmp(self.remote.SellAt) < 0) { self.In.Stop() self.Buys = false }