forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-11 23:44:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

internal/jsre, node, rpc: fix goroutine leaks in tests #24211 (#964)

Browse source
This commit is contained in:
Daniel Liu 2025-04-24 18:36:10 +08:00 committed by GitHub
parent e7ca47c280
commit d751e88fa5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
internal/jsre/jsre_test.go
View file

@ -77,20 +77,20 @@ func TestNatto(t *testing.T) {
err := jsre.Exec("test.js") err := jsre.Exec("test.js")
if err != nil { if err != nil {
t.Errorf("expected no error, got %v", err) t.Fatalf("expected no error, got %v", err)
} }
time.Sleep(100 * time.Millisecond) time.Sleep(100 * time.Millisecond)
val, err := jsre.Run("msg") val, err := jsre.Run("msg")
if err != nil { if err != nil {
t.Errorf("expected no error, got %v", err) t.Fatalf("expected no error, got %v", err)
} }
if val.ExportType().Kind() != reflect.String { if val.ExportType().Kind() != reflect.String {
t.Errorf("expected string value, got %v", val) t.Fatalf("expected string value, got %v", val)
} }
exp := "testMsg" exp := "testMsg"
got := val.ToString().String() got := val.ToString().String()
if exp != got { if exp != got {
t.Errorf("expected '%v', got '%v'", exp, got) t.Fatalf("expected '%v', got '%v'", exp, got)
} }
jsre.Stop(false) jsre.Stop(false)
} }

2
node/node_test.go
View file

@ -366,7 +366,7 @@ func TestLifecycleTerminationGuarantee(t *testing.T) {
// on the given prefix // on the given prefix
func TestRegisterHandler_Successful(t *testing.T) { func TestRegisterHandler_Successful(t *testing.T) {
node := createNode(t, 7878, 7979) node := createNode(t, 7878, 7979)
defer node.Close()
// create and mount handler // create and mount handler
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("success")) w.Write([]byte("success"))

1
rpc/client_test.go
View file

@ -686,6 +686,7 @@ func TestClientReconnect(t *testing.T) {
if err != nil { if err != nil {
t.Fatal("can't dial", err) t.Fatal("can't dial", err)
} }
defer client.Close()
// Perform a call. This should work because the server is up. // Perform a call. This should work because the server is up.
var resp echoResult var resp echoResult

2
rpc/websocket_test.go
View file

@ -76,7 +76,7 @@ func TestWebsocketOriginCheck(t *testing.T) {
// Connections without origin header should work. // Connections without origin header should work.
client, err = DialWebsocket(context.Background(), wsURL, "") client, err = DialWebsocket(context.Background(), wsURL, "")
if err != nil { if err != nil {
t.Fatal("error for empty origin") t.Fatalf("error for empty origin: %v", err)
} }
client.Close() client.Close()
} }