diff --git a/swarm/network/hive_test.go b/swarm/network/hive_test.go index ddae95a458..2b7835355b 100644 --- a/swarm/network/hive_test.go +++ b/swarm/network/hive_test.go @@ -23,6 +23,7 @@ import ( "time" "github.com/ethereum/go-ethereum/crypto" + "github.com/ethereum/go-ethereum/log" p2ptest "github.com/ethereum/go-ethereum/p2p/testing" "github.com/ethereum/go-ethereum/swarm/state" ) @@ -111,7 +112,7 @@ func TestHiveStatePersistance(t *testing.T) { dir, err := ioutil.TempDir("", "hive_test_store") if err != nil { - panic(err) + t.Fatal(err) } defer os.RemoveAll(dir) @@ -121,6 +122,8 @@ func TestHiveStatePersistance(t *testing.T) { } params := NewHiveParams() + params.Discovery = false + s, pp, err := newHiveTester(t, params, 5, store) if err != nil { t.Fatal(err) @@ -129,6 +132,7 @@ func TestHiveStatePersistance(t *testing.T) { for _, node := range s.Nodes { raddr := NewAddr(node) pp.Register(raddr) + log.Warn("add", "addr", raddr.String()) peers[raddr.String()] = true } @@ -156,12 +160,11 @@ func TestHiveStatePersistance(t *testing.T) { pp.Start(s1.Server) i := 0 pp.Kademlia.EachAddr(nil, 256, func(addr *BzzAddr, po int) bool { + log.Warn("check", "addr", addr.String()) delete(peers, addr.String()) i++ return true }) - // TODO remove this line when verified that test passes - time.Sleep(time.Second) if i != 5 { t.Fatalf("invalid number of entries: got %v, want %v", i, 5) } diff --git a/swarm/network/protocol.go b/swarm/network/protocol.go index fcceb5c31c..ad3f8df8f9 100644 --- a/swarm/network/protocol.go +++ b/swarm/network/protocol.go @@ -20,6 +20,7 @@ import ( "context" "errors" "fmt" + "math/rand" "sync" "time" @@ -37,6 +38,8 @@ const ( bzzHandshakeTimeout = 3000 * time.Millisecond ) +var DefaultTestNetworkID = rand.Uint64() + // BzzSpec is the spec of the generic swarm handshake var BzzSpec = &protocols.Spec{ Name: "bzz", diff --git a/swarm/network/protocol_test.go b/swarm/network/protocol_test.go index b655f8743a..75f9524505 100644 --- a/swarm/network/protocol_test.go +++ b/swarm/network/protocol_test.go @@ -36,10 +36,11 @@ import ( ) const ( - TestProtocolVersion = 8 - TestProtocolNetworkID = 3 + TestProtocolVersion = 8 ) +var TestProtocolNetworkID = DefaultTestNetworkID + var ( loglevel = flag.Int("loglevel", 2, "verbosity of logs") ) @@ -149,7 +150,7 @@ func newBzz(addr *BzzAddr, lightNode bool) *Bzz { OverlayAddr: addr.Over(), UnderlayAddr: addr.Under(), HiveParams: NewHiveParams(), - NetworkID: DefaultNetworkID, + NetworkID: DefaultTestNetworkID, LightNode: lightNode, } kad := NewKademlia(addr.OAddr, NewKadParams()) @@ -232,7 +233,7 @@ func TestBzzHandshakeNetworkIDMismatch(t *testing.T) { err = s.testHandshake( correctBzzHandshake(s.addr, lightNode), &HandshakeMsg{Version: TestProtocolVersion, NetworkID: 321, Addr: NewAddr(node)}, - &p2ptest.Disconnect{Peer: node.ID(), Error: fmt.Errorf("Handshake error: Message handler error: (msg code 0): network id mismatch 321 (!= 3)")}, + &p2ptest.Disconnect{Peer: node.ID(), Error: fmt.Errorf("Handshake error: Message handler error: (msg code 0): network id mismatch 321 (!= %v)", TestProtocolNetworkID)}, ) if err != nil {