forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-18 09:53:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth/filters: use map[common.Hash]struct{} instead of map[common.Hash]bool for txListen

Browse source
This commit is contained in:
Domino Valdano 2018-04-15 19:57:03 -07:00
parent 066c9f368e
commit d97a1c6f75
No known key found for this signature in database
GPG key ID: 3FDFE30EE92AC05E
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
eth/filters/api.go
View file

@ -269,7 +269,7 @@ func (api *PublicFilterAPI) ReturnData(ctx context.Context) (*rpc.Subscription,
return &rpc.Subscription{}, rpc.ErrNotificationsUnsupported return &rpc.Subscription{}, rpc.ErrNotificationsUnsupported
} }
txListen := make(map[common.Hash]bool) txListen := make(map[common.Hash]struct{})
rpcSub := notifier.CreateSubscription() rpcSub := notifier.CreateSubscription()
rpcSub.SetType(rpc.ReturnDataSubscription) rpcSub.SetType(rpc.ReturnDataSubscription)
@ -284,12 +284,12 @@ func (api *PublicFilterAPI) ReturnData(ctx context.Context) (*rpc.Subscription,
// client submitted new tx, save hash for later // client submitted new tx, save hash for later
hash, ishash := msg.(common.Hash) hash, ishash := msg.(common.Hash)
if ishash { if ishash {
txListen[hash] = true txListen[hash] = struct{}{}
} else { } else {
log.Warn(fmt.Sprintf("Received update msg of invalid type %s for ReturnData subscription", reflect.TypeOf(msg).String())) log.Warn(fmt.Sprintf("Received update msg of invalid type %s for ReturnData subscription", reflect.TypeOf(msg).String()))
} }
case retdata := <-retCh: case retdata := <-retCh:
if txListen[retdata.TxHash] { if _, has := txListen[retdata.TxHash]; has {
// tx from client just completed execution--send back return data // tx from client just completed execution--send back return data
notifier.Notify(rpcSub.ID, retdata) notifier.Notify(rpcSub.ID, retdata)
} }