forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-17 18:30:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

add comment for verify steps (#45)

Browse source
This commit is contained in:
Jerome 2022-01-27 21:15:09 +11:00 committed by GitHub
parent ff0fcd3951
commit dc15891d1f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
consensus/XDPoS/engines/engine_v2/engine.go
View file

@ -742,6 +742,10 @@ func (x *XDPoS_v2) ProposedBlockHandler(blockChainReader consensus.ChainReader,
// To be used by different message verification. Verify local DB block info against the received block information(i.e hash, blockNum, round) // To be used by different message verification. Verify local DB block info against the received block information(i.e hash, blockNum, round)
func (x *XDPoS_v2) VerifyBlockInfo(blockInfo *utils.BlockInfo) error { func (x *XDPoS_v2) VerifyBlockInfo(blockInfo *utils.BlockInfo) error {
/*
1. Check if is able to get header by hash from the chain
2. Check the header from step 1 matches what's in the blockInfo. This includes the block number and the round
*/
return nil return nil
} }
@ -789,9 +793,10 @@ func (x *XDPoS_v2) verifyQC(blockChainReader consensus.ChainReader, quorumCert *
return x.VerifyBlockInfo(quorumCert.ProposedBlockInfo) return x.VerifyBlockInfo(quorumCert.ProposedBlockInfo)
} }
// TODO: Unhold, wait till proposal finalise
func (x *XDPoS_v2) verifyTC(timeoutCert *utils.TimeoutCert) error { func (x *XDPoS_v2) verifyTC(timeoutCert *utils.TimeoutCert) error {
/* /*
1. Get epoch master node list by round/number 1. Get epoch master node list by round/number with chain's current header
2. Verify signer signature: (List of signatures) 2. Verify signer signature: (List of signatures)
- Use ecRecover to get the public key - Use ecRecover to get the public key
- Use the above public key to find out the xdc address - Use the above public key to find out the xdc address
@ -890,11 +895,16 @@ func (x *XDPoS_v2) verifyVotingRule(blockChainReader consensus.ChainReader, bloc
if x.lockQuorumCert == nil { if x.lockQuorumCert == nil {
return true, nil return true, nil
} }
if quorumCert.ProposedBlockInfo.Round > x.lockQuorumCert.ProposedBlockInfo.Round {
return true, nil
}
isExtended, err := x.isExtendingFromAncestor(blockChainReader, blockInfo, x.lockQuorumCert.ProposedBlockInfo) isExtended, err := x.isExtendingFromAncestor(blockChainReader, blockInfo, x.lockQuorumCert.ProposedBlockInfo)
if err != nil { if err != nil {
return false, err return false, err
} }
if isExtended || (quorumCert.ProposedBlockInfo.Round > x.lockQuorumCert.ProposedBlockInfo.Round) { if isExtended {
return true, nil return true, nil
} }