forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-15 19:31:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/filtermaps: return early on error in tailPartialBlocks

Browse source 
When getLastBlockOfMap fails in tailPartialBlocks, the error is
logged but the uninitialized/zero end value is still used in
the subtraction (end - start), potentially returning a garbage
block count to the caller.

Return 0 immediately on error to avoid propagating incorrect
block counts through the indexing pipeline.
This commit is contained in:
Mayveskii 2026-03-26 20:21:27 +03:00
parent 8a3a309fa9
commit dd9ed2f43d
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/filtermaps/indexer.go
View file

@ -440,12 +440,14 @@ func (f *FilterMaps) tailPartialBlocks() uint64 {
end, _, err := f.getLastBlockOfMap(f.indexedRange.maps.First() - f.mapsPerEpoch + f.indexedRange.tailPartialEpoch - 1) end, _, err := f.getLastBlockOfMap(f.indexedRange.maps.First() - f.mapsPerEpoch + f.indexedRange.tailPartialEpoch - 1)
if err != nil { if err != nil {
log.Error("Error fetching last block of map", "mapIndex", f.indexedRange.maps.First()-f.mapsPerEpoch+f.indexedRange.tailPartialEpoch-1, "error", err) log.Error("Error fetching last block of map", "mapIndex", f.indexedRange.maps.First()-f.mapsPerEpoch+f.indexedRange.tailPartialEpoch-1, "error", err)
return 0
} }
var start uint64 var start uint64
if f.indexedRange.maps.First()-f.mapsPerEpoch > 0 { if f.indexedRange.maps.First()-f.mapsPerEpoch > 0 {
start, _, err = f.getLastBlockOfMap(f.indexedRange.maps.First() - f.mapsPerEpoch - 1) start, _, err = f.getLastBlockOfMap(f.indexedRange.maps.First() - f.mapsPerEpoch - 1)
if err != nil { if err != nil {
log.Error("Error fetching last block of map", "mapIndex", f.indexedRange.maps.First()-f.mapsPerEpoch-1, "error", err) log.Error("Error fetching last block of map", "mapIndex", f.indexedRange.maps.First()-f.mapsPerEpoch-1, "error", err)
return 0
} }
} }
return end - start return end - start