From ddc897e52ccde53d77fb0856d9438ab1ae56f53d Mon Sep 17 00:00:00 2001 From: Jared Wasinger Date: Mon, 23 Dec 2024 15:43:54 +0700 Subject: [PATCH] simplify vars naming in normalizeArgs --- accounts/abi/bind/bindv2.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/accounts/abi/bind/bindv2.go b/accounts/abi/bind/bindv2.go index 2b48166944..c33f30ddd1 100644 --- a/accounts/abi/bind/bindv2.go +++ b/accounts/abi/bind/bindv2.go @@ -6,6 +6,7 @@ import ( "github.com/ethereum/go-ethereum/accounts/abi" "go/format" "regexp" + "slices" "strings" "text/template" "unicode" @@ -134,25 +135,24 @@ func (cb *contractBinder) bindMethod(original abi.Method) error { return nil } -func normalizeArgs(inp abi.Arguments) abi.Arguments { - normalizedArguments := make([]abi.Argument, len(inp)) - copy(normalizedArguments, inp) +func normalizeArgs(args abi.Arguments) abi.Arguments { + args = slices.Clone(args) used := make(map[string]bool) - for i, input := range normalizedArguments { + for i, input := range args { if input.Name == "" || isKeyWord(input.Name) { - normalizedArguments[i].Name = fmt.Sprintf("arg%d", i) + args[i].Name = fmt.Sprintf("arg%d", i) } - normalizedArguments[i].Name = capitalise(normalizedArguments[i].Name) + args[i].Name = capitalise(args[i].Name) for index := 0; ; index++ { - if !used[normalizedArguments[i].Name] { - used[normalizedArguments[i].Name] = true + if !used[args[i].Name] { + used[args[i].Name] = true break } - normalizedArguments[i].Name = fmt.Sprintf("%s%d", normalizedArguments[i].Name, index) + args[i].Name = fmt.Sprintf("%s%d", args[i].Name, index) } } - return normalizedArguments + return args } // normalizeErrorOrEventFields normalizes errors/events for emitting through bindings: