From ddf94b3e5ae3031bda77c9281727c0b5d36b4308 Mon Sep 17 00:00:00 2001
From: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Date: Fri, 2 Aug 2024 16:49:39 +0800
Subject: [PATCH] reduce number of heap allocations in tracing (#958)

---
 core/types/l2trace.go        | 18 ------------------
 eth/tracers/logger/logger.go |  8 --------
 2 files changed, 26 deletions(-)

diff --git a/core/types/l2trace.go b/core/types/l2trace.go
index c0d76f067a..1e4bf5e5b5 100644
--- a/core/types/l2trace.go
+++ b/core/types/l2trace.go
@@ -92,24 +92,6 @@ type StructLogRes struct {
 	RefundCounter uint64             `json:"refund,omitempty"`
 }
 
-// NewStructLogResBasic Basic StructLogRes skeleton, Stack&Memory&Storage&ExtraData are separated from it for GC optimization;
-// still need to fill in with Stack&Memory&Storage&ExtraData
-func NewStructLogResBasic(pc uint64, op string, gas, gasCost uint64, depth int, refundCounter uint64, err error) *StructLogRes {
-	logRes := &StructLogRes{
-		Pc:            pc,
-		Op:            op,
-		Gas:           gas,
-		GasCost:       gasCost,
-		Depth:         depth,
-		RefundCounter: refundCounter,
-	}
-
-	if err != nil {
-		logRes.Error = err.Error()
-	}
-	return logRes
-}
-
 type AccountWrapper struct {
 	Address          common.Address `json:"address"`
 	Nonce            uint64         `json:"nonce"`
diff --git a/eth/tracers/logger/logger.go b/eth/tracers/logger/logger.go
index 96f1ed4fcf..5ef1bb003c 100644
--- a/eth/tracers/logger/logger.go
+++ b/eth/tracers/logger/logger.go
@@ -80,14 +80,6 @@ type StructLog struct {
 	Err           error                       `json:"-"`
 }
 
-func (s *StructLog) clean() {
-	s.Memory = s.Memory[:0]
-	s.Stack = s.Stack[:0]
-	s.ReturnData = s.ReturnData[:0]
-	s.Storage = nil
-	s.Err = nil
-}
-
 // overrides for gencodec
 type structLogMarshaling struct {
 	Gas         math.HexOrDecimal64