forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-17 09:23:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

crypto: ensure that VerifySignature rejects malleable signatures

Browse source 
It already rejected them when using libsecp256k1, make sure the nocgo
version does the same thing.
This commit is contained in:
Felix Lange 2017-12-18 13:28:23 +01:00
parent 50df2b78be
commit df04f9e470
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crypto/signature_nocgo.go
View file

@ -87,6 +87,9 @@ func VerifySignature(pubkey, hash, signature []byte) bool {
if err != nil { if err != nil {
return false return false
} }
if !ValidateSignatureValues(0, sig.R, sig.S, true) {
return false
}
return sig.Verify(hash, key) return sig.Verify(hash, key)
} }

10
crypto/signature_test.go
View file

@ -75,6 +75,16 @@ func TestVerifySignature(t *testing.T) {
} }
} }
// This test checks that VerifySignature rejects malleable signatures with s > N/2.
func TestVerifySignatureMalleable(t *testing.T) {
sig := hexutil.MustDecode("0x638a54215d80a6713c8d523a6adc4e6e73652d859103a36b700851cb0e61b66b8ebfc1a610c57d732ec6e0a8f06a9a7a28df5051ece514702ff9cdff0b11f454")
key := hexutil.MustDecode("0x03ca634cae0d49acb401d8a4c6b6fe8c55b70d115bf400769cc1400f3258cd3138")
msg := hexutil.MustDecode("0xd301ce462d3e639518f482c7f03821fec1e602018630ce621e1e7851c12343a6")
if VerifySignature(key, msg, sig) {
t.Error("VerifySignature returned true for malleable signature")
}
}
func TestDecompressPubkey(t *testing.T) { func TestDecompressPubkey(t *testing.T) {
key, err := DecompressPubkey(testpubkeyc) key, err := DecompressPubkey(testpubkeyc)
if err != nil { if err != nil {