From df7b89603c79744d6ca201560c492c409be7dd89 Mon Sep 17 00:00:00 2001
From: cui <cuiweixie@gmail.com>
Date: Mon, 13 Jul 2026 17:06:26 +0800
Subject: [PATCH] internal/testlog: clone attributes before appending (#35324)

WithAttrs and terminalFormat appended to h.attrs directly, which can
mutate the shared slice when it has spare capacity. Clone attrs first to
avoid corrupting parent handler state.
---
 internal/testlog/testlog.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/internal/testlog/testlog.go b/internal/testlog/testlog.go
index 8a3ea85438..8993d073c7 100644
--- a/internal/testlog/testlog.go
+++ b/internal/testlog/testlog.go
@@ -22,6 +22,7 @@ import (
 	"context"
 	"fmt"
 	"log/slog"
+	"slices"
 	"sync"
 
 	"github.com/ethereum/go-ethereum/log"
@@ -76,7 +77,7 @@ func (h *bufHandler) WithAttrs(attrs []slog.Attr) slog.Handler {
 	copy(records[:], h.buf[:])
 	return &bufHandler{
 		buf:   records,
-		attrs: append(h.attrs, attrs...),
+		attrs: append(slices.Clone(h.attrs), attrs...),
 		level: h.level,
 	}
 }
@@ -186,7 +187,7 @@ func (h *bufHandler) terminalFormat(r slog.Record) string {
 		return true
 	})
 
-	attrs = append(h.attrs, attrs...)
+	attrs = append(slices.Clone(h.attrs), attrs...)
 
 	fmt.Fprintf(buf, "%s[%s] %s ", lvl, r.Time.Format(termTimeFormat), r.Message)
 	if length := len(r.Message); length < 40 {