forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 10:22:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rpc: truncate call error data logs

Browse source
This commit is contained in:
Ceyhun Onur 2024-06-19 19:03:04 +03:00
parent 27008408a5
commit e012d411b5
No known key found for this signature in database
GPG key ID: 60D53BEEE37F6422
1 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
rpc/handler.go
View file

@ -19,6 +19,7 @@ package rpc
import ( import (
"context" "context"
"encoding/json" "encoding/json"
"fmt"
"reflect" "reflect"
"strconv" "strconv"
"strings" "strings"
@ -28,6 +29,9 @@ import (
"github.com/ethereum/go-ethereum/log" "github.com/ethereum/go-ethereum/log"
) )
// callErrorDataLogDTruncateLimit is the before truncation limit of the error data field in the log.
const callErrorDataLogTruncateLimit = 1024
// handler handles JSON-RPC messages. There is one handler per connection. Note that // handler handles JSON-RPC messages. There is one handler per connection. Note that
// handler is not safe for concurrent use. Message handling never blocks indefinitely // handler is not safe for concurrent use. Message handling never blocks indefinitely
// because RPCs are processed on background goroutines launched by handler. // because RPCs are processed on background goroutines launched by handler.
@ -468,16 +472,29 @@ func (h *handler) handleCallMsg(ctx *callProc, msg *jsonrpcMessage) *jsonrpcMess
case msg.isCall(): case msg.isCall():
resp := h.handleCall(ctx, msg) resp := h.handleCall(ctx, msg)
var ctx []interface{} var logCtx []interface{}
ctx = append(ctx, "reqid", idForLog{msg.ID}, "duration", time.Since(start)) logCtx = append(logCtx, "reqid", idForLog{msg.ID}, "duration", time.Since(start))
if resp.Error != nil { if resp.Error != nil {
ctx = append(ctx, "err", resp.Error.Message) logCtx = append(logCtx, "err", resp.Error.Message)
if resp.Error.Data != nil { if resp.Error.Data != nil {
ctx = append(ctx, "errdata", resp.Error.Data) // If the log level is debug, log the full error data. Otherwise, try to truncate it.
} if h.log.Enabled(context.Background(), log.LvlDebug) {
h.log.Warn("Served "+msg.Method, ctx...) logCtx = append(logCtx, "errdata", resp.Error.Data)
} else { } else {
h.log.Debug("Served "+msg.Method, ctx...) errDataStr := fmt.Sprintf("%v", resp.Error.Data)
// Truncate the error data if it is too long. Otherwise, preserve the original data.
if len(errDataStr) > callErrorDataLogTruncateLimit {
remaining := len(errDataStr) - callErrorDataLogTruncateLimit
errDataStr = fmt.Sprintf("%s... (truncated remaining %d chars)", errDataStr[:callErrorDataLogTruncateLimit], remaining)
logCtx = append(logCtx, "errdata", errDataStr)
} else {
logCtx = append(logCtx, "errdata", resp.Error.Data)
}
}
}
h.log.Warn("Served "+msg.Method, logCtx...)
} else {
h.log.Debug("Served "+msg.Method, logCtx...)
} }
return resp return resp