forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cmd/blsync: avoid deadlock when stuck on finality update

Browse source
This commit is contained in:
lightclient 2024-01-04 13:56:27 -07:00
parent 97f0d599ae
commit e151f4a93d
No known key found for this signature in database
GPG key ID: 75C916AFEE20183E
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
cmd/blsync/chain.go
View file

@ -87,7 +87,10 @@ func (c *LightClient) Finalized() *types.Header {
// underlying light client store. // underlying light client store.
func (c *LightClient) Start() { func (c *LightClient) Start() {
log.Info("beacon light client starting") log.Info("beacon light client starting")
ticker := time.NewTicker(SecondsPerSlot * time.Second) var (
ticker = time.NewTicker(SecondsPerSlot * time.Second)
lastFinality = time.Now()
)
for ; ; <-ticker.C { for ; ; <-ticker.C {
if c.store.next == nil { if c.store.next == nil {
log.Debug("fetching committee update", "period", c.store.finalizedPeriod()) log.Debug("fetching committee update", "period", c.store.finalizedPeriod())
@ -108,23 +111,25 @@ func (c *LightClient) Start() {
update *LightClientUpdate update *LightClientUpdate
err error err error
) )
if c.store.optimistic.Slot%SlotsPerEpoch == 0 { if time.Since(lastFinality) > time.Minute*5 {
log.Debug("fetching finality update") log.Trace("fetching finality update")
lastFinality = time.Now()
update, err = c.beacon.GetFinalityUpdate() update, err = c.beacon.GetFinalityUpdate()
} else { } else {
log.Debug("fetching optimistic update") log.Trace("fetching optimistic update")
update, err = c.beacon.GetOptimisticUpdate() update, err = c.beacon.GetOptimisticUpdate()
} }
if err != nil { if err != nil {
log.Error("failed to retrieve update", "err", err) log.Error("failed to retrieve update", "err", err)
continue continue
} }
log.Trace("got update", "slot", update.AttestedHeader.Slot, "root", update.AttestedHeader.Hash(), "sigslot", update.SignatureSlot, "period", update.AttestedHeader.SyncPeriod(), "hasFinalized", update.FinalizedHeader != nil, "hasNext", update.NextSyncCommittee != nil)
if err := c.store.Insert(update); err != nil { if err := c.store.Insert(update); err != nil {
log.Error("failed to insert update", "err", err) log.Error("failed to insert update", "err", err)
continue continue
} }
head := update.AttestedHeader head := update.AttestedHeader
log.Info("updated head", "slot", head.Slot, "root", head.Hash(), "finalized", c.Finalized().Hash(), "signers", update.SyncAggregate.SignerCount()) log.Info("beacon head updated", "slot", head.Slot, "root", head.Hash(), "finalized", c.Finalized().Hash(), "signers", update.SyncAggregate.SignerCount())
// Fetch full execution payload from beacon provider and send to head feed. // Fetch full execution payload from beacon provider and send to head feed.
data, err := c.getExecutableData(head.Hash()) data, err := c.getExecutableData(head.Hash())