forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-22 15:59:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/types: fix CopyHeader missing BlockAccessListHash deep copy

Browse source 
CopyHeader copies all pointer-typed header fields (WithdrawalsHash,
RequestsHash, SlotNumber, etc.) but was missing the deep copy for
BlockAccessListHash added by EIP-7928. This caused the BAL hash
to be silently shared between the original and the copy, leading
to potential data races and incorrect nil-checks on copied headers.
This commit is contained in:
CPerezz 2026-02-14 11:15:48 +01:00 committed by MariusVanDerWijden
parent a46bd22ba9
commit e1521be67a
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/types/block.go
View file

@ -333,6 +333,10 @@ func CopyHeader(h *Header) *Header {
cpy.RequestsHash = new(common.Hash) cpy.RequestsHash = new(common.Hash)
*cpy.RequestsHash = *h.RequestsHash *cpy.RequestsHash = *h.RequestsHash
} }
if h.BlockAccessListHash != nil {
cpy.BlockAccessListHash = new(common.Hash)
*cpy.BlockAccessListHash = *h.BlockAccessListHash
}
if h.SlotNumber != nil { if h.SlotNumber != nil {
cpy.SlotNumber = new(uint64) cpy.SlotNumber = new(uint64)
*cpy.SlotNumber = *h.SlotNumber *cpy.SlotNumber = *h.SlotNumber