forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

p2p : Add missing calls timer/ticker.Stop() for p2p tests

Browse source
This commit is contained in:
ucwong 2020-04-02 11:22:17 +00:00
parent 66ed58bfcc
commit e38b59db53
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
p2p/discv5/sim_test.go
View file

@ -43,6 +43,7 @@ func TestSimRandomResolve(t *testing.T) {
// A new node joins every 10s.
launcher := time.NewTicker(10 * time.Second)
defer launcher.Stop()
go func() {
for range launcher.C {
net := sim.launchNode(false)
@ -55,7 +56,6 @@ func TestSimRandomResolve(t *testing.T) {
}()
time.Sleep(3 * time.Hour)
launcher.Stop()
sim.shutdown()
sim.printStats()
}
@ -196,6 +196,7 @@ func randomResolves(t *testing.T, s *simulation, net *Network) {
}
timer := time.NewTimer(randtime())
defer timer.Stop()
for {
select {
case <-timer.C:

1
p2p/testing/protocolsession.go
View file

@ -242,6 +242,7 @@ func (s *ProtocolSession) testExchange(e Exchange) error {
t = 2000 * time.Millisecond
}
alarm := time.NewTimer(t)
defer alarm.Stop()
select {
case err := <-errc:
return err