forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-19 21:31:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

trie: remove unused makeHashNode #24702 (#1089)

Browse source 
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
This commit is contained in:
Daniel Liu 2025-06-17 13:28:59 +08:00 committed by GitHub
parent 205a94ea4f
commit e4de0e82a2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
trie/committer.go
View file

@ -22,8 +22,6 @@ import (
"sync"
"github.com/XinFinOrg/XDPoSChain/common"
"github.com/XinFinOrg/XDPoSChain/crypto"
"golang.org/x/crypto/sha3"
)
// leafChanSize is the size of the leafCh. It's a pretty arbitrary number, to allow
@ -44,8 +42,6 @@ type leaf struct {
// By 'some level' of parallelism, it's still the case that all leaves will be
// processed sequentially - onleaf will never be called in parallel or out of order.
type committer struct {
sha crypto.KeccakState
onleaf LeafCallback
leafCh chan *leaf
}
@ -53,9 +49,7 @@ type committer struct {
// committers live in a global sync.Pool
var committerPool = sync.Pool{
New: func() interface{} {
return &committer{
sha: sha3.NewLegacyKeccak256().(crypto.KeccakState),
}
return &committer{}
},
}
@ -231,15 +225,7 @@ func (c *committer) commitLoop(db *Database) {
}
}
func (c *committer) makeHashNode(data []byte) hashNode {
n := make(hashNode, c.sha.Size())
c.sha.Reset()
c.sha.Write(data)
c.sha.Read(n)
return n
}
// estimateSize estimates the size of an rlp-encoded Node, without actually
// estimateSize estimates the size of an rlp-encoded node, without actually
// rlp-encoding it (zero allocs). This method has been experimentally tried, and with a trie
// with 1000 leafs, the only errors above 1% are on small shortnodes, where this
// method overestimates by 2 or 3 bytes (e.g. 37 instead of 35)