From e8b23da4cd6c1e4e8fd6fdb239bc486ba2debf5b Mon Sep 17 00:00:00 2001
From: colinlyguo <colinlyguo@scroll.io>
Date: Tue, 13 Feb 2024 21:35:00 +0800
Subject: [PATCH] refactor Cap to use heap.Pop() instead of sorting the whole
 heap

---
 core/txpool/legacypool/list.go | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/core/txpool/legacypool/list.go b/core/txpool/legacypool/list.go
index 2b3bde6384..de7db2ac49 100644
--- a/core/txpool/legacypool/list.go
+++ b/core/txpool/legacypool/list.go
@@ -160,12 +160,11 @@ func (m *sortedMap) Cap(threshold int) types.Transactions {
 	// Otherwise gather and drop the highest nonce'd transactions
 	var drops types.Transactions
 
-	sort.Sort(*m.index)
 	for size := len(m.items); size > threshold; size-- {
-		drops = append(drops, m.items[(*m.index)[size-1]])
-		delete(m.items, (*m.index)[size-1])
+		dropIdx := m.index.Pop().(uint64)
+		drops = append(drops, m.items[dropIdx])
+		delete(m.items, dropIdx)
 	}
-	*m.index = (*m.index)[:threshold]
 
 	// If we had a cache, shift the back
 	m.cacheMu.Lock()