From eaf06e30a037dd7d206404c8b2022db892308acb Mon Sep 17 00:00:00 2001
From: Jonas Theis <4181434+jonastheis@users.noreply.github.com>
Date: Mon, 28 Apr 2025 15:10:10 +0800
Subject: [PATCH] feat(L1Reader): change to NextUnfinalizedL1MessageQueueIndex
 and add GetFinalizedStateRootByBatchIndex (#1160)

* change FinalizedL1MessageQueueIndex to NextUnfinalizedL1MessageQueueIndex

* feat(L1Reader): add GetFinalizedStateRootByBatchIndex (#1165)

* feat(L1Reader): add GetFinalizedStateRootByBatchIndex

* fix: FinalizedL1MessageQueueIndex return type

* fix: get state root batchIndex type

---------

Co-authored-by: Morty <70688412+yiweichi@users.noreply.github.com>
---
 rollup/l1/reader.go | 31 +++++++++++++++++++++++++------
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/rollup/l1/reader.go b/rollup/l1/reader.go
index f2b5ce6c7e..e479b7dd9d 100644
--- a/rollup/l1/reader.go
+++ b/rollup/l1/reader.go
@@ -23,6 +23,7 @@ const (
 	finalizeBatchEventName    = "FinalizeBatch"
 	nextUnfinalizedQueueIndex = "nextUnfinalizedQueueIndex"
 	lastFinalizedBatchIndex   = "lastFinalizedBatchIndex"
+	finalizedStateRoots       = "finalizedStateRoots"
 
 	defaultRollupEventsFetchBlockRange = 100
 )
@@ -72,7 +73,7 @@ func NewReader(ctx context.Context, config Config, l1Client Client) (*Reader, er
 	return &reader, nil
 }
 
-func (r *Reader) FinalizedL1MessageQueueIndex(blockNumber uint64) (uint64, error) {
+func (r *Reader) NextUnfinalizedL1MessageQueueIndex(blockNumber uint64) (uint64, error) {
 	data, err := r.l1MessageQueueABI.Pack(nextUnfinalizedQueueIndex)
 	if err != nil {
 		return 0, fmt.Errorf("failed to pack %s: %w", nextUnfinalizedQueueIndex, err)
@@ -92,11 +93,7 @@ func (r *Reader) FinalizedL1MessageQueueIndex(blockNumber uint64) (uint64, error
 	}
 
 	next := parsedResult.Uint64()
-	if next == 0 {
-		return 0, nil
-	}
-
-	return next - 1, nil
+	return next, nil
 }
 
 func (r *Reader) LatestFinalizedBatchIndex(blockNumber uint64) (uint64, error) {
@@ -121,6 +118,28 @@ func (r *Reader) LatestFinalizedBatchIndex(blockNumber uint64) (uint64, error) {
 	return parsedResult.Uint64(), nil
 }
 
+func (r *Reader) GetFinalizedStateRootByBatchIndex(blockNumber uint64, batchIndex uint64) (common.Hash, error) {
+	data, err := r.scrollChainABI.Pack(finalizedStateRoots, big.NewInt(int64(batchIndex)))
+	if err != nil {
+		return common.Hash{}, fmt.Errorf("failed to pack %s: %w", finalizedStateRoots, err)
+	}
+
+	result, err := r.client.CallContract(r.ctx, ethereum.CallMsg{
+		To:   &r.config.ScrollChainAddress,
+		Data: data,
+	}, new(big.Int).SetUint64(blockNumber))
+	if err != nil {
+		return common.Hash{}, fmt.Errorf("failed to call %s: %w", finalizedStateRoots, err)
+	}
+
+	var parsedResult common.Hash
+	if err = r.scrollChainABI.UnpackIntoInterface(&parsedResult, finalizedStateRoots, result); err != nil {
+		return common.Hash{}, fmt.Errorf("failed to unpack result: %w", err)
+	}
+
+	return parsedResult, nil
+}
+
 // GetLatestFinalizedBlockNumber fetches the block number of the latest finalized block from the L1 chain.
 func (r *Reader) GetLatestFinalizedBlockNumber() (uint64, error) {
 	header, err := r.client.HeaderByNumber(r.ctx, big.NewInt(int64(rpc.FinalizedBlockNumber)))