forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-04 22:18:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/txpool: drop reorged v0 blob sidecars (#35099)
Some checks are pending
/ Linux Build (push) Waiting to run
Details
/ Linux Build (arm) (push) Waiting to run
Details
/ Keeper Build (push) Waiting to run
Details
/ Windows Build (push) Waiting to run
Details
/ Docker Image (push) Waiting to run
Details

Browse source 
With Osaka being a while ago I believe we can drop this transition and
drop the tx instead.
This commit is contained in:
Sina M 2026-06-03 15:26:18 +02:00 committed by GitHub
parent 6b451a4245
commit eb429a062a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
core/txpool/blobpool/blobpool.go
View file

@ -166,14 +166,6 @@ func (ptx *blobTxForPool) Sidecar() *types.BlobTxSidecar {
return types.NewBlobTxSidecar(ptx.Version, ptx.Blobs, ptx.Commitments, ptx.Proofs) return types.NewBlobTxSidecar(ptx.Version, ptx.Blobs, ptx.Commitments, ptx.Proofs)
} }
// ApplySidecar copies the sidecar's fields into the flat fields.
func (ptx *blobTxForPool) ApplySidecar(sc *types.BlobTxSidecar) {
ptx.Version = sc.Version
ptx.Commitments = sc.Commitments
ptx.Proofs = sc.Proofs
ptx.Blobs = sc.Blobs
}
// TxSize returns the transaction size on the network without // TxSize returns the transaction size on the network without
// reconstructing the transaction. // reconstructing the transaction.
func (ptx *blobTxForPool) TxSize() uint64 { func (ptx *blobTxForPool) TxSize() uint64 {
@ -1274,22 +1266,13 @@ func (p *BlobPool) reinject(addr common.Address, txhash common.Hash) error {
// TODO: seems like an easy optimization here would be getting the serialized tx // TODO: seems like an easy optimization here would be getting the serialized tx
// from limbo instead of re-serializing it here. // from limbo instead of re-serializing it here.
// Converts reorged-out legacy blob transactions to the new format to prevent // Post-Osaka, legacy (v0) blob sidecars are no longer accepted into the pool.
// them from becoming stuck in the pool until eviction. // A reorged-out legacy blob transaction can therefore not be re-added, so drop
// // it on the floor instead of putting it back.
// Performance note: Conversion takes ~140ms (Mac M1 Pro). Since a maximum of
// 9 legacy blob transactions are allowed in a block pre-Osaka, an adversary
// could theoretically halt a Geth node for ~1.2s by reorging per block. However,
// this attack is financially inefficient to execute.
head := p.head.Load() head := p.head.Load()
if p.chain.Config().IsOsaka(head.Number, head.Time) && ptx.Version == types.BlobSidecarVersion0 { if p.chain.Config().IsOsaka(head.Number, head.Time) && ptx.Version == types.BlobSidecarVersion0 {
sc := ptx.Sidecar() log.Debug("Dropping reorged legacy blob transaction", "hash", txhash)
if err := sc.ToV1(); err != nil { return errors.New("legacy blob sidecar unsupported post-osaka")
log.Error("Failed to convert the legacy sidecar", "err", err)
return err
}
ptx.ApplySidecar(sc)
log.Info("Legacy blob transaction is reorged", "hash", ptx.Tx.Hash())
} }
blob, err := rlp.EncodeToBytes(ptx) blob, err := rlp.EncodeToBytes(ptx)
if err != nil { if err != nil {