From ebcabb7b3eef7ce57a83ab1faa0fab93d2267f7b Mon Sep 17 00:00:00 2001 From: Jared Wasinger Date: Sat, 4 Oct 2025 14:30:20 +0800 Subject: [PATCH] fix some failing tests --- core/types/bal/bal.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/core/types/bal/bal.go b/core/types/bal/bal.go index 9cad845d7a..217231a03f 100644 --- a/core/types/bal/bal.go +++ b/core/types/bal/bal.go @@ -199,6 +199,9 @@ func (a *AccessListBuilder) FinaliseIdxChanges() (*StateDiff, StateAccesses) { access.storageReads[key] = struct{}{} } } + if len(access.storageMutations) == 0 { + access.storageMutations = nil + } } // two scenarios where an account can become non-existent: @@ -219,6 +222,13 @@ func (a *AccessListBuilder) FinaliseIdxChanges() (*StateDiff, StateAccesses) { stateAccesses[addr] = access.storageReads } continue + } else if !createdInTx && access.code == nil && access.nonce == nil && access.balance == nil && len(access.storageMutations) == 0 { + // TODO: refactor this path + // path description: if the net mutations of an account are zero, it ends up as a read. + + // TODO: if I remove this branch, why doesn't the affected tests silently pass? + stateAccesses[addr] = access.storageReads + continue } stateAccesses[addr] = access.storageReads