forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 02:12:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/vm: minor clarification in retf control flow validation

Browse source
This commit is contained in:
Martin Holst Swende 2024-09-30 19:56:04 +02:00
parent 03d36ac908
commit edec35510e
No known key found for this signature in database
GPG key ID: 683B438C05A5DDF0
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
core/vm/eof_control_flow.go
View file

@ -62,15 +62,20 @@ func validateControlFlow(code []byte, section int, metadata []*functionMetadata,
currentStackMax += delta currentStackMax += delta
currentStackMin += delta currentStackMin += delta
case RETF: case RETF:
/* From the spec:
> for RETF the following must hold: stack_height_max == stack_height_min == types[current_code_index].outputs,
In other words: RETF must unambiguously return all items remaining on the stack.
*/
if currentStackMax != currentStackMin { if currentStackMax != currentStackMin {
return 0, fmt.Errorf("%w: max %d, min %d, at pos %d", errInvalidOutputs, currentStackMax, currentStackMin, pos) return 0, fmt.Errorf("%w: max %d, min %d, at pos %d", errInvalidOutputs, currentStackMax, currentStackMin, pos)
} }
have := int(metadata[section].outputs) numOutputs := int(metadata[section].outputs)
if have >= maxOutputItems { if numOutputs >= maxOutputItems {
return 0, fmt.Errorf("%w: at pos %d", errInvalidNonReturningFlag, pos) return 0, fmt.Errorf("%w: at pos %d", errInvalidNonReturningFlag, pos)
} }
if want := currentStackMin; have != want { if numOutputs != currentStackMin {
return 0, fmt.Errorf("%w: have %d, want %d, at pos %d", errInvalidOutputs, have, want, pos) return 0, fmt.Errorf("%w: have %d, want %d, at pos %d", errInvalidOutputs, numOutputs, currentStackMin, pos)
} }
qualifiedExit = true qualifiedExit = true
case JUMPF: case JUMPF: