eth: avoid blocking when geth is closed, fix hang in waitSnapExtension

This commit is contained in:
niuxiaojie81 2024-01-15 10:31:41 +08:00
parent 3758223e35
commit f05fcaa489

View file

@ -131,7 +131,6 @@ func (ps *peerSet) waitSnapExtension(peer *eth.Peer) (*snap.Peer, error) {
ps.snapWait[id] = wait
ps.lock.Unlock()
for {
select {
case p := <-wait:
return p, nil
@ -142,7 +141,6 @@ func (ps *peerSet) waitSnapExtension(peer *eth.Peer) (*snap.Peer, error) {
return nil, errPeerSetClosed
}
}
}
// registerPeer injects a new `eth` peer into the working set, or returns an error
// if the peer is already known.
@ -268,6 +266,8 @@ func (ps *peerSet) close() {
for _, p := range ps.peers {
p.Disconnect(p2p.DiscQuitting)
}
if !ps.closed {
close(ps.quitCh)
}
ps.closed = true
}