forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-03 14:52:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/txpool/blobpool: remove unused txValidationFn from BlobPool (#32237)
Some checks failed
/ Linux Build (arm) (push) Has been cancelled
Details
/ Windows Build (push) Has been cancelled
Details
/ Docker Image (push) Has been cancelled
Details
/ Linux Build (push) Has been cancelled
Details

Browse source 
This PR removes the now‑unused `txValidationFn` field from BlobPool.
It became obsolete after a PR  https://github.com/ethereum/go-ethereum/pull/31202 
was merged.

Resolves https://github.com/ethereum/go-ethereum/issues/32236
This commit is contained in:
kourin 2025-07-18 19:36:10 +09:00 committed by GitHub
parent b4b4068fe7
commit f17df6db91
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/txpool/blobpool/blobpool.go
View file

@ -326,10 +326,6 @@ type BlobPool struct {
discoverFeed event.Feed // Event feed to send out new tx events on pool discovery (reorg excluded) discoverFeed event.Feed // Event feed to send out new tx events on pool discovery (reorg excluded)
insertFeed event.Feed // Event feed to send out new tx events on pool inclusion (reorg included) insertFeed event.Feed // Event feed to send out new tx events on pool inclusion (reorg included)
// txValidationFn defaults to txpool.ValidateTransaction, but can be
// overridden for testing purposes.
txValidationFn txpool.ValidationFunction
lock sync.RWMutex // Mutex protecting the pool during reorg handling lock sync.RWMutex // Mutex protecting the pool during reorg handling
} }
@ -348,7 +344,6 @@ func New(config Config, chain BlockChain, hasPendingAuth func(common.Address) bo
lookup: newLookup(), lookup: newLookup(),
index: make(map[common.Address][]*blobTxMeta), index: make(map[common.Address][]*blobTxMeta),
spent: make(map[common.Address]*uint256.Int), spent: make(map[common.Address]*uint256.Int),
txValidationFn: txpool.ValidateTransaction,
} }
} }

6
core/txpool/blobpool/blobpool_test.go
View file

@ -1724,12 +1724,6 @@ func benchmarkPoolPending(b *testing.B, datacap uint64) {
// Make the pool not use disk (just drop everything). This test never reads // Make the pool not use disk (just drop everything). This test never reads
// back the data, it just iterates over the pool in-memory items // back the data, it just iterates over the pool in-memory items
pool.store = &fakeBilly{pool.store, 0} pool.store = &fakeBilly{pool.store, 0}
// Avoid validation - verifying all blob proofs take significant time
// when the capacity is large. The purpose of this bench is to measure assembling
// the lazies, not the kzg verifications.
pool.txValidationFn = func(tx *types.Transaction, head *types.Header, signer types.Signer, opts *txpool.ValidationOptions) error {
return nil // accept all
}
// Fill the pool up with one random transaction from each account with the // Fill the pool up with one random transaction from each account with the
// same price and everything to maximize the worst case scenario // same price and everything to maximize the worst case scenario
for i := 0; i < int(capacity); i++ { for i := 0; i < int(capacity); i++ {