From f1ec95b87bcae91ecd3c5acc9fb4a44d57c6a7ab Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Thu, 14 Jun 2018 11:13:37 +0200 Subject: [PATCH] common: fixups --- common/hexutil/hexutil.go | 2 +- common/math/big.go | 5 ++--- common/mclock/mclock.go | 6 +++--- common/types.go | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/common/hexutil/hexutil.go b/common/hexutil/hexutil.go index e80be278b2..46223a2815 100644 --- a/common/hexutil/hexutil.go +++ b/common/hexutil/hexutil.go @@ -39,7 +39,7 @@ import ( const uintBits = 32 << (uint64(^uint(0)) >> 63) -// Variables that specify custom error messages. +// Errors var ( ErrEmptyString = &decError{"empty hex string"} ErrSyntax = &decError{"invalid hex string"} diff --git a/common/math/big.go b/common/math/big.go index ac61381a9a..9d2e7946d1 100644 --- a/common/math/big.go +++ b/common/math/big.go @@ -22,14 +22,13 @@ import ( "math/big" ) -// Variables allocated a new Int set used to find complement numbers -// and bound maximum byte lengths. +// Various big integer limit values. var ( tt255 = BigPow(2, 255) tt256 = BigPow(2, 256) tt256m1 = new(big.Int).Sub(tt256, big.NewInt(1)) - MaxBig256 = new(big.Int).Set(tt256m1) tt63 = BigPow(2, 63) + MaxBig256 = new(big.Int).Set(tt256m1) MaxBig63 = new(big.Int).Sub(tt63, big.NewInt(1)) ) diff --git a/common/mclock/mclock.go b/common/mclock/mclock.go index 3425364b6b..02608d17b0 100644 --- a/common/mclock/mclock.go +++ b/common/mclock/mclock.go @@ -23,10 +23,10 @@ import ( "github.com/aristanetworks/goarista/monotime" ) -// AbsTime will convert an integer number of units to a Duration in hours. -type AbsTime time.Duration // absolute monotonic time +// AbsTime represents absolute monotonic time. +type AbsTime time.Duration -// Now returns the current time, as a Duration, in nanoseconds from a monotonic clock +// Now returns the current absolute monotonic time. func Now() AbsTime { return AbsTime(monotime.Now()) } diff --git a/common/types.go b/common/types.go index 4e94da8760..4d374ad246 100644 --- a/common/types.go +++ b/common/types.go @@ -29,7 +29,7 @@ import ( "github.com/ethereum/go-ethereum/crypto/sha3" ) -// Const expresses the required byte length for hashes and addresses. +// Lengths of hashes and addresses in bytes. const ( HashLength = 32 AddressLength = 20