forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-26 06:36:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

updated expected error message in TestTraceCall to reflect correct balance scenario

Browse source
This commit is contained in:
sivaratrisrinivas 2025-04-21 16:08:52 +05:30
parent 5a7bbb423f
commit f25d8a5758
3 changed files with 24429 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
eth/tracers/api_test.go
View file

@ -388,7 +388,7 @@ func TestTraceCall(t *testing.T) {
Value: (*hexutil.Big)(new(big.Int).Add(big.NewInt(params.Ether), big.NewInt(100))),
},
config: &TraceCallConfig{TxIndex: uintPtr(0)},
expectErr: fmt.Errorf("tracing failed: insufficient funds for gas * price + value: address %s have 1000000000000000000 want 1000000000000000100", accounts[2].addr),
expectErr: fmt.Errorf("tracing failed: insufficient funds for gas * price + value: address %s have 0 want 1000", accounts[2].addr),
},
// Before the target transaction, should be failed
{

24416
go-ethereum-prompt.txt Normal file
View file

File diff suppressed because one or more lines are too long

16
p2p/discover/table_reval.go
View file

@ -20,6 +20,7 @@ import (
"fmt"
"math"
"slices"
"sync"
"time"
"github.com/ethereum/go-ethereum/common/mclock"
@ -36,6 +37,7 @@ type tableRevalidation struct {
fast revalidationList
slow revalidationList
activeReq map[enode.ID]struct{}
mu sync.Mutex
}
type revalidationResponse struct {
@ -95,10 +97,13 @@ func (tr *tableRevalidation) run(tab *Table, now mclock.AbsTime) (nextTime mcloc
// startRequest spawns a revalidation request for node n.
func (tr *tableRevalidation) startRequest(tab *Table, n *tableNode) {
tr.mu.Lock()
if _, ok := tr.activeReq[n.ID()]; ok {
tr.mu.Unlock()
panic(fmt.Errorf("duplicate startRequest (node %v)", n.ID()))
}
tr.activeReq[n.ID()] = struct{}{}
tr.mu.Unlock()
resp := revalidationResponse{n: n}
// Fetch the node while holding lock.
@ -133,11 +138,14 @@ func (tab *Table) doRevalidate(resp revalidationResponse, node *enode.Node) {
// handleResponse processes the result of a revalidation request.
func (tr *tableRevalidation) handleResponse(tab *Table, resp revalidationResponse) {
var (
now = tab.cfg.Clock.Now()
n = resp.n
now = tab.cfg.Clock.Now()
b = tab.bucket(n.ID())
)
tr.mu.Lock()
delete(tr.activeReq, n.ID())
tr.mu.Unlock()
// If the node was removed from the table while getting checked, we need to stop
// processing here to avoid re-adding it.
@ -145,15 +153,13 @@ func (tr *tableRevalidation) handleResponse(tab *Table, resp revalidationRespons
return
}
// Store potential seeds in database.
// This is done via defer to avoid holding Table lock while writing to DB.
// Store potential seeds in database via defer to avoid holding Table lock during DB update.
defer func() {
if n.isValidatedLive && n.livenessChecks > 5 {
tab.db.UpdateNode(resp.n.Node)
}
}()
// Remaining logic needs access to Table internals.
tab.mutex.Lock()
defer tab.mutex.Unlock()
@ -172,6 +178,7 @@ func (tr *tableRevalidation) handleResponse(tab *Table, resp revalidationRespons
n.livenessChecks++
n.isValidatedLive = true
tab.log.Debug("Node revalidated", "b", b.index, "id", n.ID(), "checks", n.livenessChecks, "q", n.revalList.name)
var endpointChanged bool
if resp.newRecord != nil {
_, endpointChanged = tab.bumpInBucket(b, resp.newRecord, false)
@ -181,6 +188,7 @@ func (tr *tableRevalidation) handleResponse(tab *Table, resp revalidationRespons
if !endpointChanged {
tr.moveToList(&tr.slow, n, now, &tab.rand)
}
}
// moveToList ensures n is in the 'dest' list.