chore(ci): add go catch-all job (#140)

## Why this should be merged

New jobs are easily forgotten in the GitHub rules so we will only gate
on `go` and have all others added as dependencies.

## How this works

Same as #139 

## How this was tested

Inspection of CI run:

![image](https://github.com/user-attachments/assets/f76ce720-a5ed-49e6-b000-265f3660ce8f)
This commit is contained in:
Arran Schlosberg 2025-02-14 17:56:51 +00:00 committed by GitHub
parent bc42e5f29c
commit f7a3a4f548
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 12 deletions

View file

@ -12,6 +12,14 @@ concurrency:
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
jobs:
# If adding a new job, add it to the `needs` list of the `go` job as this is
# what gates PRs.
go:
runs-on: ubuntu-latest
needs: [go_test_short, go_test_tooling, go_generate, go_tidy]
steps:
- run: echo "Dependencies successful"
go_test_short:
env:
FLAKY_REGEX: "ava-labs/libevm/(triedb/pathdb|eth|eth/tracers/js|eth/tracers/logger|accounts/abi/bind|accounts/keystore|eth/downloader|miner|ethclient|ethclient/gethclient|eth/catalyst)$"
@ -62,7 +70,7 @@ jobs:
- name: git diff
run: git diff --exit-code
go_tidy_matrix:
go_tidy:
runs-on: ubuntu-latest
strategy:
matrix:
@ -78,11 +86,3 @@ jobs:
go-version-file: "${{ matrix.dir }}/go.mod"
- run: go mod tidy
- run: git diff --exit-code
go_tidy:
# Each matrix instance runs as a different name, which doesn't play nicely
# with branch-protection rules. We instead require this job.
needs: go_tidy_matrix
runs-on: ubuntu-latest
steps:
- run: echo "Dependencies successful"

View file

@ -1,8 +1,5 @@
name: lint
# If adding a new linter: (a) create a new job; and (b) add it to the `needs`
# list of the `lint` job as this is what gates PRs.
on:
push:
branches: [main, "release/**"]
@ -21,6 +18,8 @@ concurrency:
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
jobs:
# If adding a new linter: (a) create a new job; and (b) add it to the `needs`
# list of the `lint` job as this is what gates PRs.
lint:
runs-on: ubuntu-latest
needs: [golangci-lint, yamllint, shellcheck]