From f883dcdc21fce4a793f92fa0e46254c158eb1cca Mon Sep 17 00:00:00 2001 From: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Date: Tue, 29 Aug 2023 08:05:27 +0800 Subject: [PATCH] docs(ccc): add more logs for skipping msg (#490) * docs(ccc): add more logs for skipping msg * bump version * format codes * improve --- miner/worker.go | 5 ++++- params/version.go | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/miner/worker.go b/miner/worker.go index 3742d4421e..3476d26688 100644 --- a/miner/worker.go +++ b/miner/worker.go @@ -1071,6 +1071,7 @@ loop: // though it might still be possible to add some "smaller" txs, // but it's a trade-off between tracing overhead & block usage rate log.Trace("Circuit capacity limit reached in a block", "acc_rows", w.current.accRows, "tx", tx.Hash().String()) + log.Info("Skipping message", "tx", tx.Hash().String(), "block", w.current.header.Number, "reason", "accumulated row consumption overflow") circuitCapacityReached = true break loop } else { @@ -1083,10 +1084,11 @@ loop: txs.Shift() queueIndex := tx.AsL1MessageTx().QueueIndex - log.Info("Skipping L1 message", "queueIndex", queueIndex, "tx", tx.Hash().String(), "block", w.current.header.Number, "reason", "row consumption overflow") + log.Info("Skipping L1 message", "queueIndex", queueIndex, "tx", tx.Hash().String(), "block", w.current.header.Number, "reason", "first tx row consumption overflow") w.current.nextL1MsgIndex = queueIndex + 1 } else { // Skip L2 transaction and all other transactions from the same sender account + log.Info("Skipping L2 message", "tx", tx.Hash().String(), "block", w.current.header.Number, "reason", "first tx row consumption overflow") txs.Pop() } @@ -1118,6 +1120,7 @@ loop: case (errors.Is(err, circuitcapacitychecker.ErrUnknown) && !tx.IsL1MessageTx()): // Circuit capacity check: unknown circuit capacity checker error for L2MessageTx, skip the account log.Trace("Unknown circuit capacity checker error for L2MessageTx", "tx", tx.Hash().String()) + log.Info("Skipping L2 message", "tx", tx.Hash().String(), "block", w.current.header.Number, "reason", "unknown row consumption error") // Normally we would do `txs.Pop()` here. // However, after `ErrUnknown`, ccc might remain in an diff --git a/params/version.go b/params/version.go index e2ec33324e..44d4eacb2b 100644 --- a/params/version.go +++ b/params/version.go @@ -24,7 +24,7 @@ import ( const ( VersionMajor = 4 // Major version component of the current release VersionMinor = 3 // Minor version component of the current release - VersionPatch = 54 // Patch version component of the current release + VersionPatch = 55 // Patch version component of the current release VersionMeta = "sepolia" // Version metadata to append to the version string )