forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 15:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

p2p/nat: do not use UPnP delete workaround by default

Browse source 
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
This commit is contained in:
Csaba Kiraly 2025-04-03 14:22:08 +02:00
parent 2a517dab64
commit f9018208f3
No known key found for this signature in database
GPG key ID: 0FE274EE8C95166E
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
p2p/nat/natupnp.go
View file

@ -37,6 +37,13 @@ const (
rateLimit = 200 * time.Millisecond rateLimit = 200 * time.Millisecond
retryCount = 3 // number of retries after a failed AddPortMapping retryCount = 3 // number of retries after a failed AddPortMapping
randomCount = 3 // number of random ports to try randomCount = 3 // number of random ports to try
// According to the UPnP spec delete before add is not needed if the
// private IP remained the same. However, we have seen this workaround
// being used in practice. It could also create problems, so we keep it
// disabled by default. If the private IP changed, an external port change
// should be OK.
deleteBeforeAdd = false
) )
type upnp struct { type upnp struct {
@ -93,7 +100,7 @@ func (n *upnp) AddMapping(protocol string, extport, intport int, desc string, li
if extport == 0 { if extport == 0 {
extport = intport extport = intport
} else { } else if deleteBeforeAdd {
// Only delete port mapping if the external port was already used by geth. // Only delete port mapping if the external port was already used by geth.
err := n.DeleteMapping(protocol, extport, intport) err := n.DeleteMapping(protocol, extport, intport)
log.Trace("Deleting port mapping", "protocol", protocol, "extport", extport, "intport", intport, "err", err) log.Trace("Deleting port mapping", "protocol", protocol, "extport", extport, "intport", intport, "err", err)