forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-22 12:46:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/txpool/locals: fix unsafe nonce comparator in TxTracker.recheck journal sort

Browse source
This commit is contained in:
Snezhkko 2025-11-26 10:20:01 +02:00 committed by GitHub
parent 960c87a944
commit fbae079252
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/txpool/locals/tx_tracker.go
View file

@ -151,7 +151,13 @@ func (tracker *TxTracker) recheck(journalCheck bool) []*types.Transaction {
for _, list := range rejournal {
// cmp(a, b) should return a negative number when a < b,
slices.SortFunc(list, func(a, b *types.Transaction) int {
return int(a.Nonce() - b.Nonce())
if a.Nonce() < b.Nonce() {
return -1
}
if a.Nonce() > b.Nonce() {
return 1
}
return 0
})
}
// Rejournal the tracker while holding the lock. No new transactions will