From fd461323fc7d006de1ed37fc17081cb2dd7cb9c9 Mon Sep 17 00:00:00 2001 From: Chase Wright Date: Mon, 30 Mar 2026 09:27:41 -0500 Subject: [PATCH] eth/tracers/logger: use omitzero for legacy error omission Use a plain string field with omitzero for the legacy structLog error field so the JSON shape stays unchanged without pointer indirection. --- eth/tracers/logger/logger.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/eth/tracers/logger/logger.go b/eth/tracers/logger/logger.go index 57e4cd2df2..7f2b2aecf2 100644 --- a/eth/tracers/logger/logger.go +++ b/eth/tracers/logger/logger.go @@ -148,7 +148,7 @@ type structLogLegacy struct { Gas uint64 `json:"gas"` GasCost uint64 `json:"gasCost"` Depth int `json:"depth"` - Error *string `json:"error,omitempty"` + Error string `json:"error,omitempty,omitzero"` Stack *[]string `json:"stack,omitempty"` ReturnData string `json:"returnData,omitempty"` Memory *[]string `json:"memory,omitempty"` @@ -173,11 +173,9 @@ func (s *StructLog) toLegacyJSON() json.RawMessage { Gas: s.Gas, GasCost: s.GasCost, Depth: s.Depth, + Error: s.ErrorString(), RefundCounter: s.RefundCounter, } - if err := s.ErrorString(); err != "" { - msg.Error = &err - } if s.Stack != nil { stack := make([]string, len(s.Stack)) for i, stackValue := range s.Stack {