forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-17 17:33:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

whisper: fix issue in topic list copy

Browse source 
Fixes #16271. What was appeneded was a pointer to
an object that changes during the iteration.
This commit is contained in:
Guillaume Ballet 2018-03-23 16:35:50 +01:00
parent 85ea9159d0
commit fd8a2786d4
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
whisper/whisperv6/api.go
View file

@ -558,9 +558,10 @@ func (api *PublicWhisperAPI) NewMessageFilter(req Criteria) (string, error) {
}
if len(req.Topics) > 0 {
topics = make([][]byte, 0, len(req.Topics))
for _, topic := range req.Topics {
topics = append(topics, topic[:])
topics = make([][]byte, len(req.Topics))
for i, topic := range req.Topics {
topics = append(topics, make([]byte, 0, len(topic)))
copy(topics[i], topic[:])
}
}