Commit graph

3 commits

Author SHA1 Message Date
Chase Wright
75e4fe44c5
eth/catalyst: drop flaky txpool subtest for TestCommitBlockV1
After the prior commit subtests advanced the chain, the txpool's
internal Reset() is asynchronous. On slower runners (observed on the
Windows amd64 CI image) GetPoolNonce returns a stale value before
Reset has processed the new head, the signed tx gets rejected as
nonce-too-low, and the committed block lands empty.

The from-mempool path is optional per spec ("MAY build from mempool")
and is already covered by the hive commit-block-z-from-mempool SpecOnly
fixture, so removing this unit-test variant doesn't lose coverage.
2026-05-18 09:58:34 -05:00
Chase Wright
bcca4858b5
eth/catalyst, miner: add testing_commitBlockV1
testing_commitBlockV1 is the write companion of testing_buildBlockV1: it
builds a block from the provided payloadAttributes and txs, inserts it,
and sets it as the canonical head, returning the new head hash. Skipping
the engine_newPayload + engine_forkchoiceUpdated serialize/deserialize
round-trip makes it useful for state-shape benchmarking and reproducible
test-chain construction where the caller wants the chain to advance.

The new miner.CommitTestingBlock shares its generation path with
BuildTestingPayload via an unexported helper, so both code paths produce
the same block from the same inputs.

Spec and cross-client fixtures: ethereum/execution-apis#801
2026-05-18 09:36:10 -05:00
Marius van der Wijden
e40aa46e88
eth/catalyst: implement testing_buildBlockV1 (#33656)
implements
https://github.com/ethereum/execution-apis/pull/710/changes#r2712256529

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
2026-02-23 15:56:31 +01:00