Daniel Liu
0cbaccd106
accounts/keystore: simplify tests using t.TempDir() ( #30150 )
2025-01-24 16:54:12 +08:00
Daniel Liu
62895df693
accounts/keystore: use t.TempDir in test ( #30052 )
2025-01-24 16:54:12 +08:00
Daniel Liu
643c715b43
accounts: fix TestUpdateKeyfileContents ( #29867 )
...
Create the directory before NewKeyStore. This ensures the watcher successfully starts on
the first attempt, and waitWatcherStart functions as intended.
2025-01-24 16:54:12 +08:00
Daniel Liu
ef71887d7a
accounts, cmd/geth, core: close opened files ( #29598 )
...
* fix: open file used up but not closed
* feat: more same case
* feat: accept conversation
2025-01-24 16:54:12 +08:00
Daniel Liu
733a5fc193
accounts: fix mismatched names in comments ( #29348 )
2025-01-24 16:54:12 +08:00
Daniel Liu
dfc0f112b8
accounts/keystore: use min/max/clear from go1.21 ( #29307 )
2025-01-24 16:54:12 +08:00
Daniel Liu
888963c6ff
accounts: remove deprecated function NewPlaintextKeyStore ( #29171 )
2025-01-24 16:54:12 +08:00
Daniel Liu
0e7679dc6a
accounts,signer: fix typos in comments ( #28730 )
2025-01-24 16:54:12 +08:00
Daniel Liu
4a54407eb9
accounts: run tests in parallel ( #28544 )
2025-01-24 16:54:12 +08:00
Daniel Liu
f804203609
accounts/keystore: speed up tests ( #28461 )
2025-01-24 16:54:12 +08:00
Daniel Liu
ccda15ef5d
accounts, cmd: fix typos ( #28526 )
2025-01-24 16:54:12 +08:00
Daniel Liu
5081ad72f5
accounts: move fuzzers into native packages ( #28467 )
2025-01-24 16:54:12 +08:00
Daniel Liu
3e880ef27d
cmd/clef: suppress fsnotify error if keydir not exists ( #28160 )
...
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
2025-01-24 16:54:12 +08:00
Daniel Liu
3bce105c95
accounts: use atomic type ( #27857 )
2025-01-24 16:54:12 +08:00
Daniel Liu
f365434a0c
accounts/keystore: use slices package for sorting ( #27485 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2025-01-24 16:54:12 +08:00
Daniel Liu
a57f3583fc
accounts/keystore: handle error for invalid key in DecryptKey ( #27432 )
...
Co-authored-by: KAI <kaili@coinsummer.io>
Co-authored-by: Felix Lange <fjl@twurst.com>
2025-01-24 16:54:12 +08:00
Daniel Liu
d4bf06d689
accounts: replace noarg fmt.Errorf with errors.New ( #27331 )
...
* accounts: replace noarg fmt.Errorf with errors.New
Signed-off-by: jsvisa <delweng@gmail.com>
* accounts: go autoimport
Signed-off-by: jsvisa <delweng@gmail.com>
---------
Signed-off-by: jsvisa <delweng@gmail.com>
2025-01-24 16:54:12 +08:00
Daniel Liu
3d90cf7de2
accounts/keystore: remove deprecated uses of math.rand ( #26710 )
2025-01-24 16:54:11 +08:00
Daniel Liu
4e951ed8fe
all: use github.com/deckarep/golang-set/v2 (generic set) ( #26159 )
2025-01-24 16:54:11 +08:00
Daniel Liu
4081ed926a
accounts/keystore: replace inotify with fsnotify ( #26176 )
2025-01-24 16:54:11 +08:00
Daniel Liu
a79d2a2ed3
accounts/keystore: faster tests ( #25827 )
...
This PR removes some optimistic tests -- a'la "do something,
wait a while, and hope it has trickled through and continue" -- and
instead uses some introspection to ensure that prerequisites are met.
2025-01-24 16:54:11 +08:00
Daniel Liu
c046f36afd
accounts: fix some typos ( #25551 )
2025-01-24 16:54:11 +08:00
Daniel Liu
78a35f1dc3
accounts: lint whitespace ( #25312 )
2025-01-24 16:54:11 +08:00
Daniel Liu
9dda5b9819
accounts: more linters ( #24783 )
2025-01-24 16:54:11 +08:00
Daniel Liu
5b10b2441c
all: use T.TempDir to create temporary test directories ( #24633 )
2025-01-24 16:54:08 +08:00
Daniel Liu
bcae4205e4
accounts/keystore: fix flaky tests ( #23599 )
...
* ethclient/gethclient: fix flaky test (due to map key ordering)
* accounts/keystore: fix test failing due to rand collision due to low time resolution on windows
2025-01-24 16:18:30 +08:00
Daniel Liu
83b7c0eacb
accounts/keystore: add go:build lines ( #23468 )
2025-01-24 16:18:30 +08:00
Daniel Liu
c75ba99267
accounts/keystore: use github.com/google/uuid ( #22217 )
...
This replaces the github.com/pborman/uuid dependency with
github.com/google/uuid because the former is only a wrapper for
the latter (since v1.0.0).
Co-authored-by: Felix Lange <fjl@twurst.com>
2025-01-24 16:18:30 +08:00
Daniel Liu
146ea8ba78
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 ( #21502 )
2025-01-24 16:18:30 +08:00
Daniel Liu
2ffdb94855
accounts/keystore: remove uneeded syntax ( #21921 )
2025-01-24 16:18:30 +08:00
Daniel Liu
05e9dc0def
accounts/keystore: add missing function doc for SignText ( #21914 )
...
Co-authored-by: Pascal Dierich <pascal@pascaldierich.com>
2025-01-24 16:18:30 +08:00
Daniel Liu
25284155d8
accounts: remove redundant conversions and import names ( #21903 )
2025-01-24 16:18:30 +08:00
Daniel Liu
d02ba1db81
accounts/keystore: fix flaky test ( #21703 )
...
* accounts/keystore: add timeout to test to prevent failure on travis
The TestWalletNotifications test sporadically fails on travis.
This is because we shutdown the event collection before all events are received.
Adding a small timeout (10 milliseconds) allows the collector to be scheduled
and to consume all pending events before we shut it down.
* accounts/keystore: added newlines back in
* accounts/keystore: properly fix the walletNotifications test
2025-01-24 16:18:30 +08:00
Daniel Liu
d8c9ad3c9f
all: replace RWMutex with Mutex in places where RLock is not used ( #21622 )
2025-01-24 16:18:30 +08:00
Daniel Liu
9c5dff2554
accounts/keystore: fix typo in error message ( #21200 )
2025-01-24 16:18:29 +08:00
Daniel Liu
5e3755c46a
accounts/keystore, cmd/faucet: return old account to allow unlock ( #21173 )
2025-01-24 16:18:29 +08:00
Daniel Liu
d918e53c8a
acounts/keystore, cmd/faucet: fix faucet double import ( #21172 )
2025-01-24 16:18:29 +08:00
Daniel Liu
0d1cd42dc2
accounts/keystore: fix double import race ( #20915 )
...
* accounts/keystore: fix race in Import/ImportECDSA
* accounts/keystore: added import/export tests
* cmd/geth: improved TestAccountImport test
* accounts/keystore: added import/export tests
* accounts/keystore: fixed naming
* accounts/keystore: fixed typo
* accounts/keystore: use mutex instead of rwmutex
* accounts: use errors instead of fmt
2025-01-24 16:18:29 +08:00
Daniel Liu
833c851361
accounts/keystore: fix staticcheck warnings ( #20373 )
...
* accounts/keystore: fix staticcheck warnings
* review feedback
2025-01-24 16:18:29 +08:00
Daniel Liu
e90df44b43
accounts: replace passPHRASE with passWORD in any user interactions ( #19932 )
2025-01-24 16:18:29 +08:00
Daniel Liu
07ebb5ef12
accounts/keystore: fix #19707 , avoid keyword as variable name ( #19731 )
2025-01-24 16:18:29 +08:00
Daniel Liu
00fbe17f2e
accounts/keystore: enable fallback for darwin,!cgo ( #19614 )
...
Without this, accounts/keystore fails to build for Darwin with
CGO_ENABLED=0.
2025-01-24 16:18:29 +08:00
Daniel Liu
fa35614784
accounts, cmd: add note about backing up the keystore ( #19432 )
2025-01-24 16:18:29 +08:00
Daniel Liu
194a77505f
accounts: switch Ledger derivation path to canonical one ( #19438 )
2025-01-24 16:18:29 +08:00
Daniel Liu
4955476db4
accounts: prefer nil slices over zero-length slices ( #19079 )
2025-01-24 16:18:29 +08:00
Daniel Liu
43e6c8ecdc
accounts: implemented EIP191/712 ( #17789 )
2025-01-24 16:18:29 +08:00
Daniel Liu
07935ce124
accounts: support for external signer API ( #18079 )
2025-01-24 16:18:29 +08:00
Daniel Liu
fe14069bd7
accounts: support for external signer API ( #18079 )
2025-01-24 16:18:29 +08:00
Daniel Liu
a81fe22903
accounts/keystore: small code simplification ( #18394 )
2025-01-24 16:18:28 +08:00
Daniel Liu
e4adf8e4eb
accounts/keystore: fix comment typo ( #18395 )
2025-01-24 16:18:28 +08:00